Commit d558dcd
committed
minor #97 Inline $tmpDir (derrabus)
This PR was merged into the 2.1-dev branch.
Discussion
----------
Inline $tmpDir
This PR fixes an issue where the variable `$tmpDir` of `CovertTest` is used in a data provider before it is initialized through the `setUp()` method. Inlining the variable avoids this trap and makes the whole code a bit clearer.
I spotted this while running the tests with PHP 8.1 where passing `null` to `tempnam()` triggers a deprecation warning.
Commits
-------
d152649 Inline $tmpDir1 file changed
+1
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | | - | |
39 | 37 | | |
40 | 38 | | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
44 | | - | |
45 | | - | |
46 | 42 | | |
47 | 43 | | |
48 | 44 | | |
| |||
233 | 229 | | |
234 | 230 | | |
235 | 231 | | |
236 | | - | |
| 232 | + | |
237 | 233 | | |
238 | 234 | | |
239 | 235 | | |
| |||
0 commit comments