Leverage PHP8's get_debug_type()

Author: nicolas-grekas

MarkingStore/MethodMarkingStore.php

@@ -51,7 +51,7 @@ public function getMarking(object $subject): Marking
         $method = 'get'.ucfirst($this->property);
 
         if (!method_exists($subject, $method)) {
-            throw new LogicException(sprintf('The method "%s::%s()" does not exist.', \get_class($subject), $method));
+            throw new LogicException(sprintf('The method "%s::%s()" does not exist.', get_debug_type($subject), $method));
         }
 
         $marking = $subject->{$method}();
@@ -81,7 +81,7 @@ public function setMarking(object $subject, Marking $marking, array $context = [
         $method = 'set'.ucfirst($this->property);
 
         if (!method_exists($subject, $method)) {
-            throw new LogicException(sprintf('The method "%s::%s()" does not exist.', \get_class($subject), $method));
+            throw new LogicException(sprintf('The method "%s::%s()" does not exist.', get_debug_type($subject), $method));
         }
 
         $subject->{$method}($marking, $context);

Metadata/GetMetadataTrait.php

@@ -43,6 +43,6 @@ public function getMetadata(string $key, $subject = null)
             return $metadataBag[$key] ?? null;
         }
 
-        throw new InvalidArgumentException(sprintf('Could not find a MetadataBag for the subject of type "%s".', \is_object($subject) ? \get_class($subject) : \gettype($subject)));
+        throw new InvalidArgumentException(sprintf('Could not find a MetadataBag for the subject of type "%s".', get_debug_type($subject)));
     }
 }

Registry.php

@@ -52,15 +52,15 @@ public function get(object $subject, string $workflowName = null)
         }
 
         if (!$matched) {
-            throw new InvalidArgumentException(sprintf('Unable to find a workflow for class "%s".', \get_class($subject)));
+            throw new InvalidArgumentException(sprintf('Unable to find a workflow for class "%s".', get_debug_type($subject)));
         }
 
         if (2 <= \count($matched)) {
             $names = array_map(static function (WorkflowInterface $workflow): string {
                 return $workflow->getName();
             }, $matched);
 
-            throw new InvalidArgumentException(sprintf('Too many workflows (%s) match this subject (%s); set a different name on each and use the second (name) argument of this method.', implode(', ', $names), \get_class($subject)));
+            throw new InvalidArgumentException(sprintf('Too many workflows (%s) match this subject (%s); set a different name on each and use the second (name) argument of this method.', implode(', ', $names), get_debug_type($subject)));
         }
 
         return $matched[0];

Tests/Metadata/InMemoryMetadataStoreTest.php

@@ -78,7 +78,7 @@ public function testGetMetadata()
     public function testGetMetadataWithUnknownType()
     {
         $this->expectException('Symfony\Component\Workflow\Exception\InvalidArgumentException');
-        $this->expectExceptionMessage('Could not find a MetadataBag for the subject of type "boolean".');
+        $this->expectExceptionMessage('Could not find a MetadataBag for the subject of type "bool".');
         $this->store->getMetadata('title', true);
     }
 }

composer.json

@@ -20,7 +20,8 @@
         }
     ],
     "require": {
-        "php": "^7.2.5"
+        "php": "^7.2.5",
+        "symfony/polyfill-php80": "^1.15"
     },
     "require-dev": {
         "psr/log": "~1.0",