Transfers Polishing

[ovitrif]

This issue is to track enhancements for polishing transfers-related features.

Currently there's a dependency on ldk-node adding support to link transactions to channels.

One solution that might land sooner is proposed in the rust-lightning#3566 issue:

• Add APIs to classify channel-related transaction types lightningdevkit/rust-lightning#3566

---

Section copied from #414 feat: pending transfer balance:

Next steps:

• Backups: data backup for transfers & integration in backup status UI for this category
• Activity List: dual transfer listing with associated 'To Spending' item for a 'To Savings' transfer and vice-versa non RN feature
• Activity: direct management of activity records instead of the current, complex timed augmentation via cached metadata
• Activity List: force transfer activity list items non RN feature:
  • 'Force Transfer to Savings (± 10d)' item while force closing
  • 'Force Transfer to Savings' item after force closed
  • 'Pending' item (optional, if really relevant)
• Activity List: best time estimates in transfer items subtitle text (e.g.: (± 10d))
• Activity Details: transfer_pending status text with correct duration for 'confirms in X' text
• Lightning Node Screen: List pending balances from ldk-node’s BalanceDetails.pendingBalancesFromChannelClosures using same UI from .lightingBalances
• Suggestion Cards: for Channel Closure (first check if still relevant in design v58):
  • Initiating (exists but needs logic polish)
  • Transfer in Progress
  • Transfer Ready in ± 14 days
• Channels:
  • Introduce Channels Repo to track closed channels for List & Detail screens
  • build domain model from blocktank orders to represent pending channels, replacing the current fake pending ChannelDetails representation
• Activity: Add temp fix to ldk-node to address missing link between onchain payments and lightning channels ¹
  • or wait for prioritized upstream PR to fix lightningdevkit/rust-lightning#3566
• (stretch) Research:
  • Transfer to spending activities should compare ChannelDetailsconfirmationsRequired to confirmationsRequired for accurate display of confirmation status and time estimate in activity list.
    • note that it was inaccurate for docker LND channels in one of my tests: it showed 3 while it required 6
    • maybe reacting to channel events is still the better option

Footnotes

1. See ldk-node comment in wallet/mod.rs ↩