Skip to content

Commit e2c6de4

Browse files
committed
refactor(ui): renamings
1 parent 8664701 commit e2c6de4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+237
-289
lines changed

src/components/BottomSheetWrapper.tsx renamed to src/components/BottomSheet.tsx

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,14 @@ import { useReducedMotion } from 'react-native-reanimated';
1212
import { __E2E__ } from '../constants/env';
1313
import useColors from '../hooks/colors';
1414
import { useAppDispatch, useAppSelector } from '../hooks/redux';
15-
import {
16-
SheetId,
17-
useSheetRef,
18-
} from '../navigation/bottom-sheet/SheetRefsProvider';
19-
import { viewControllerSelector } from '../store/reselect/ui';
15+
import { useSheetRef } from '../navigation/bottom-sheet/SheetRefsProvider';
16+
import { sheetSelector } from '../store/reselect/ui';
2017
import { resetSheet } from '../store/slices/ui';
18+
import { SheetId } from '../store/types/ui';
2119
import BottomSheetBackground from './BottomSheetBackground';
2220

2321
type SheetProps = {
24-
view: SheetId;
22+
id: SheetId;
2523
snapPoints: number[];
2624
children: ReactNode;
2725
testID?: string;
@@ -30,18 +28,18 @@ type SheetProps = {
3028
};
3129

3230
const Sheet = ({
33-
view,
31+
id,
3432
snapPoints,
3533
children,
3634
testID,
3735
onOpen,
3836
onClose,
3937
}: SheetProps) => {
4038
const colors = useColors();
41-
const sheetRef = useSheetRef(view);
39+
const sheetRef = useSheetRef(id);
4240
const isReducedMotion = useReducedMotion();
4341
const dispatch = useAppDispatch();
44-
const data = useAppSelector((state) => viewControllerSelector(state, view));
42+
const data = useAppSelector((state) => sheetSelector(state, id));
4543

4644
// https://github.com/gorhom/react-native-bottom-sheet/issues/770#issuecomment-1072113936
4745
// do not activate BottomSheet if swipe horizontally, this allows using Swiper inside of it
@@ -81,17 +79,17 @@ const Sheet = ({
8179
if (index === -1) {
8280
onClose?.();
8381
// clear sheet params
84-
dispatch(resetSheet(view));
82+
dispatch(resetSheet(id));
8583
} else if (index >= 0) {
8684
onOpen?.();
8785
}
8886
},
89-
[onOpen, onClose, dispatch, view],
87+
[onOpen, onClose, dispatch, id],
9088
);
9189

9290
return (
9391
<BottomSheetModal
94-
name={view}
92+
name={id}
9593
ref={sheetRef}
9694
snapPoints={snapPoints}
9795
handleStyle={styles.handle}

src/components/PinPad.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const PinPad = ({
3131
onShowBiotmetrics?: () => void;
3232
}): ReactElement => {
3333
const { t } = useTranslation('security');
34-
const sheetRef = useSheetRef('forgotPIN');
34+
const sheetRef = useSheetRef('forgotPin');
3535
const [biometryData, setBiometricData] = useState<IsSensorAvailableResult>();
3636
const { attemptsRemaining, Dots, handleNumberPress, isLastAttempt, loading } =
3737
usePIN(onSuccess);

src/components/Suggestions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const Suggestions = (): ReactElement => {
2828
const { t } = useTranslation('cards');
2929
const navigation = useNavigation<RootNavigationProp>();
3030
const backupSheetRef = useSheetRef('backupPrompt');
31-
const pinSheetRef = useSheetRef('PINNavigation');
31+
const pinSheetRef = useSheetRef('pinNavigation');
3232
const { width } = useWindowDimensions();
3333
const dispatch = useAppDispatch();
3434
const pinTodoDone = useAppSelector(pinSelector);

src/components/TabBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { rootNavigation } from '../navigation/root/RootNavigationContainer';
1919
import type { RootNavigationProp } from '../navigation/types';
2020
import { resetSendTransaction } from '../store/actions/wallet';
2121
import { spendingOnboardingSelector } from '../store/reselect/aggregations';
22-
import { showBottomSheet } from '../store/utils/ui';
22+
import { showSheet } from '../store/utils/ui';
2323
import { ScanIcon } from '../styles/icons';
2424
import ButtonBlur from './buttons/ButtonBlur';
2525

@@ -37,7 +37,7 @@ const TabBar = (): ReactElement => {
3737

3838
// if we are on the spending screen and the user has not yet received funds
3939
if (currentRoute === 'ActivitySpending' && isSpendingOnboarding) {
40-
showBottomSheet('receiveNavigation', { receiveScreen: 'ReceiveAmount' });
40+
showSheet('receiveNavigation', { receiveScreen: 'ReceiveAmount' });
4141
} else {
4242
receiveSheetRef.current?.present();
4343
}

src/navigation/bottom-sheet/AppUpdatePrompt.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import React, { memo, ReactElement, useEffect } from 'react';
22
import { Trans, useTranslation } from 'react-i18next';
33

4+
import BottomSheet from '../../components/BottomSheet';
45
import BottomSheetScreen from '../../components/BottomSheetScreen';
5-
import BottomSheetWrapper from '../../components/BottomSheetWrapper';
66
import { __E2E__ } from '../../constants/env';
77
import { useSnapPoints } from '../../hooks/bottomSheet';
88
import { useAppDispatch, useAppSelector } from '../../hooks/redux';
@@ -18,7 +18,7 @@ const imageSrc = require('../../assets/illustrations/wand.png');
1818
const ASK_INTERVAL = 1000 * 60 * 60 * 12; // 12h - how long this prompt will be hidden if user taps Later
1919
const CHECK_DELAY = 2500; // how long user needs to stay on the home screen before he will see this prompt
2020

21-
const sheetId = 'appUpdatePrompt';
21+
const sheetId = 'appUpdate';
2222

2323
const AppUpdatePrompt = (): ReactElement => {
2424
const { t } = useTranslation('other');
@@ -73,10 +73,7 @@ const AppUpdatePrompt = (): ReactElement => {
7373
};
7474

7575
return (
76-
<BottomSheetWrapper
77-
view={sheetId}
78-
snapPoints={snapPoints}
79-
onClose={onClose}>
76+
<BottomSheet id={sheetId} snapPoints={snapPoints} onClose={onClose}>
8077
<BottomSheetScreen
8178
navTitle={t('update_nav_title')}
8279
title={
@@ -95,7 +92,7 @@ const AppUpdatePrompt = (): ReactElement => {
9592
onContinue={onUpdate}
9693
onCancel={onCancel}
9794
/>
98-
</BottomSheetWrapper>
95+
</BottomSheet>
9996
);
10097
};
10198

src/navigation/bottom-sheet/BackupNavigation.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ import {
66
} from '@react-navigation/native-stack';
77
import React, { ReactElement, memo } from 'react';
88

9-
import BottomSheetWrapper from '../../components/BottomSheetWrapper';
9+
import BottomSheet from '../../components/BottomSheet';
1010
import { __E2E__ } from '../../constants/env';
1111
import { useSnapPoints } from '../../hooks/bottomSheet';
12-
import { useAppSelector } from '../../hooks/redux';
1312
import ConfirmMnemonic from '../../screens/Settings/Backup/ConfirmMnemonic';
1413
import ConfirmPassphrase from '../../screens/Settings/Backup/ConfirmPassphrase';
1514
import Metadata from '../../screens/Settings/Backup/Metadata';
@@ -18,7 +17,6 @@ import ShowMnemonic from '../../screens/Settings/Backup/ShowMnemonic';
1817
import ShowPassphrase from '../../screens/Settings/Backup/ShowPassphrase';
1918
import Success from '../../screens/Settings/Backup/Success';
2019
import Warning from '../../screens/Settings/Backup/Warning';
21-
import { viewControllerIsOpenSelector } from '../../store/reselect/ui';
2220
import BottomSheetNavigationContainer from './BottomSheetNavigationContainer';
2321

2422
export type BackupNavigationProp =
@@ -44,14 +42,11 @@ const navOptions: NativeStackNavigationOptions = {
4442

4543
const BackupNavigation = (): ReactElement => {
4644
const snapPoints = useSnapPoints('medium');
47-
const isOpen = useAppSelector((state) => {
48-
return viewControllerIsOpenSelector(state, 'backupNavigation');
49-
});
5045

5146
return (
52-
<BottomSheetWrapper view="backupNavigation" snapPoints={snapPoints}>
47+
<BottomSheet id="backupNavigation" snapPoints={snapPoints}>
5348
<NavigationIndependentTree>
54-
<BottomSheetNavigationContainer key={isOpen.toString()}>
49+
<BottomSheetNavigationContainer>
5550
<Stack.Navigator screenOptions={navOptions}>
5651
<Stack.Screen name="ShowMnemonic" component={ShowMnemonic} />
5752
<Stack.Screen name="ShowPassphrase" component={ShowPassphrase} />
@@ -67,7 +62,7 @@ const BackupNavigation = (): ReactElement => {
6762
</Stack.Navigator>
6863
</BottomSheetNavigationContainer>
6964
</NavigationIndependentTree>
70-
</BottomSheetWrapper>
65+
</BottomSheet>
7166
);
7267
};
7368

src/navigation/bottom-sheet/BackupPrompt.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import React, { memo, ReactElement, useEffect } from 'react';
22
import { Trans, useTranslation } from 'react-i18next';
33

4+
import BottomSheet from '../../components/BottomSheet';
45
import BottomSheetScreen from '../../components/BottomSheetScreen';
5-
import BottomSheetWrapper from '../../components/BottomSheetWrapper';
66
import { __E2E__ } from '../../constants/env';
77
import { useSnapPoints } from '../../hooks/bottomSheet';
88
import { useAppDispatch, useAppSelector } from '../../hooks/redux';
@@ -74,8 +74,8 @@ const BackupPrompt = (): ReactElement => {
7474
const text = totalBalance > 0 ? t('backup_funds') : t('backup_funds_no');
7575

7676
return (
77-
<BottomSheetWrapper
78-
view={sheetId}
77+
<BottomSheet
78+
id={sheetId}
7979
snapPoints={snapPoints}
8080
onClose={(): void => {
8181
dispatch(ignoreBackup());
@@ -98,7 +98,7 @@ const BackupPrompt = (): ReactElement => {
9898
onContinue={handleBackup}
9999
onCancel={handleLater}
100100
/>
101-
</BottomSheetWrapper>
101+
</BottomSheet>
102102
);
103103
};
104104

src/navigation/bottom-sheet/BottomSheets.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { JSX, memo } from 'react';
22
// import { useAppSelector } from '../../hooks/redux';
3-
// import { viewControllersSelector } from '../../store/reselect/ui';
3+
// import { sheetsSelector } from '../../store/reselect/ui';
44
// import TransferFailed from '../bottom-sheet/TransferFailed';
55

66
import BoostPrompt from '../../screens/Wallets/BoostPrompt';
@@ -16,7 +16,7 @@ import ReceiveNavigation from './ReceiveNavigation';
1616
import SendNavigation from './SendNavigation';
1717

1818
const BottomSheets = (): JSX.Element => {
19-
// const views = useAppSelector(viewControllersSelector);
19+
// const views = useAppSelector(sheetsSelector);
2020

2121
return (
2222
<>

src/navigation/bottom-sheet/ConnectionClosed.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import React, { memo, ReactElement } from 'react';
22
import { useTranslation } from 'react-i18next';
33
import { Image, StyleSheet, View } from 'react-native';
44

5+
import BottomSheet from '../../components/BottomSheet';
56
import BottomSheetNavigationHeader from '../../components/BottomSheetNavigationHeader';
6-
import BottomSheetWrapper from '../../components/BottomSheetWrapper';
77
import SafeAreaInset from '../../components/SafeAreaInset';
88
import Button from '../../components/buttons/Button';
99
import { useSnapPoints } from '../../hooks/bottomSheet';
@@ -22,7 +22,7 @@ const ConnectionClosed = (): ReactElement => {
2222
};
2323

2424
return (
25-
<BottomSheetWrapper view="connectionClosed" snapPoints={snapPoints}>
25+
<BottomSheet id="connectionClosed" snapPoints={snapPoints}>
2626
<View style={styles.container}>
2727
<BottomSheetNavigationHeader
2828
title={t('connection_closed.title')}
@@ -44,7 +44,7 @@ const ConnectionClosed = (): ReactElement => {
4444
</View>
4545
<SafeAreaInset type="bottom" minPadding={16} />
4646
</View>
47-
</BottomSheetWrapper>
47+
</BottomSheet>
4848
);
4949
};
5050

src/navigation/bottom-sheet/ForceTransfer.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import React, { memo, ReactElement, useEffect, useState } from 'react';
22
import { Trans, useTranslation } from 'react-i18next';
33

4+
import BottomSheet from '../../components/BottomSheet';
45
import BottomSheetScreen from '../../components/BottomSheetScreen';
5-
import BottomSheetWrapper from '../../components/BottomSheetWrapper';
66
import { useSnapPoints } from '../../hooks/bottomSheet';
77
import { useAppDispatch, useAppSelector } from '../../hooks/redux';
88
import { startCoopCloseTimestampSelector } from '../../store/reselect/user';
@@ -110,7 +110,7 @@ const ForceTransfer = (): ReactElement => {
110110
};
111111

112112
return (
113-
<BottomSheetWrapper view="forceTransfer" snapPoints={snapPoints}>
113+
<BottomSheet id="forceTransfer" snapPoints={snapPoints}>
114114
<BottomSheetScreen
115115
navTitle={t('force_nav_title')}
116116
title={
@@ -129,7 +129,7 @@ const ForceTransfer = (): ReactElement => {
129129
onContinue={onContinue}
130130
onCancel={onCancel}
131131
/>
132-
</BottomSheetWrapper>
132+
</BottomSheet>
133133
);
134134
};
135135

0 commit comments

Comments
 (0)