Check container name if numeric

Author: Patrick Rose

lib/OpenCloud/ObjectStore/Service.php

@@ -92,7 +92,7 @@ public function listContainers(array $filter = array())
      */
     public function getContainer($data = null)
     {
-        if (is_string($data)) {
+        if (is_string($data) || is_numeric($data)) {
             $this->checkContainerName($data);
         }
 

tests/OpenCloud/Tests/ObjectStore/ServiceTest.php

@@ -123,6 +123,24 @@ public function test_Get_Bad_Container_Name_Long()
         $this->service->getContainer(str_repeat('a', Service::MAX_CONTAINER_NAME_LENGTH + 1));
     }
 
+    /**
+     * @expectedException OpenCloud\Common\Exceptions\InvalidArgumentError
+     */
+    public function test_Get_Bad_Container_Name_Float()
+    {
+        $this->service->getContainer(4.5);
+    }
+
+    public function test_Get_Container_String()
+    {
+        $this->assertInstanceOf('OpenCloud\ObjectStore\Resource\Container', $this->service->getContainer('foo'));
+    }
+
+    public function test_Get_Container_Integer()
+    {
+        $this->assertInstanceOf('OpenCloud\ObjectStore\Resource\Container', $this->service->getContainer(1));
+    }
+
     public function test_Bulk_Extract()
     {
         $response = $this->service->bulkExtract('fooBarContainer', 'CONTENT', UrlType::TAR);
@@ -166,7 +184,8 @@ public function test_Batch_Delete_Returns_Array_Of_Responses()
     {
         $responses = array_fill(0, 2, new Response(200));
 
-        foreach ($responses as $response) {
+        foreach ($responses as $response)
+        {
             $this->addMockSubscriber($response);
         }