feat!: upgrade terraform 1.3 and remove experimental (#132)

since sept 21 terraform 1.3 graduated optional usage, and hence, breaks
compatibility with `experiments = [module_variable_optional_attrs]
experiment opt-in` usage

https://www.terraform.io/language/upgrade-guides#concluding-the-optional-attributes-experiment

from now on, customers require terraform 1.3, or are required to pin the
secure for cloud module to latest compatible version
```
module "secure-for-cloud" {
  source  = "sysdiglabs/secure-for-cloud/aws"
  version = "0.9.10"
}
```

Author: iru

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,10 +3,10 @@ Thank you for your contribution!
 
 ## Testing your PR
 
-You can pinpoint the pr changes as terraform module source with following format 
+You can pinpoint the pr changes as terraform module source with following format
 
 ```
-source                    = "github.com/sysdiglabs/terraform-aws-secure-for-cloud//examples/organizational?ref=<BRANCH_NAME>" 
+source                    = "github.com/sysdiglabs/terraform-aws-secure-for-cloud//examples/organizational?ref=<BRANCH_NAME>"
 ```
 
 

.github/workflows/ci-integration-tests.yaml

@@ -26,6 +26,13 @@ jobs:
       TF_VAR_sysdig_secure_api_token: ${{secrets.KUBELAB_SECURE_API_TOKEN}}
 
     steps:
+      # remove this tf setup with 1.3.1 is released for github runner (it fixes an impacting bug)
+      # https://github.com/actions/runner-images/pull/6346
+      # hashicorp/setup-terraform@v2 requires wrapper set to false
+      # https://github.com/newcontext-oss/kitchen-terraform/issues/411#issuecomment-953920206
+      - uses: hashicorp/setup-terraform@v2
+        with:
+          terraform_wrapper: false
       - name: Checkout
         uses: actions/checkout@v2
 
@@ -110,6 +117,9 @@ jobs:
       TF_VAR_sysdig_secure_api_token: ${{secrets.KUBELAB_SECURE_API_TOKEN}}
 
     steps:
+      - uses: hashicorp/setup-terraform@v2
+        with:
+          terraform_wrapper: false
       - name: Checkout
         uses: actions/checkout@v2
 
@@ -179,6 +189,9 @@ jobs:
       TF_VAR_sysdig_secure_api_token: ${{secrets.KUBELAB_SECURE_API_TOKEN}}
 
     steps:
+      - uses: hashicorp/setup-terraform@v2
+        with:
+          terraform_wrapper: false
       - name: Checkout
         uses: actions/checkout@v2
 

.github/workflows/ci-pull-request.yaml

@@ -32,7 +32,7 @@ jobs:
     outputs:
       directories: ${{ steps.matrix.outputs.directories }}
 
-  # Min Terraform version(s)
+  # min Terraform version(s)
   preCommitMinVersions:
     name: Min TF validate
     needs: getModules
@@ -49,14 +49,14 @@ jobs:
 
       - name: Terraform min/max versions
         id: minMax
-        uses: clowdhaus/terraform-min-max@v1.0.2
+        uses: clowdhaus/terraform-min-max@v1.1.1
         with:
           directory: ${{ matrix.directory }}
 
       - name: Echo Terraform min/max versions
         run: |
-          echo "min version ${{ steps.minMax.outputs.minVersion }}"
-          echo "max version ${{ steps.minMax.outputs.maxVersion }}"
+          echo "min version for ${{ matrix.directory }}: ${{ steps.minMax.outputs.minVersion }}"
+          echo "max version for ${{ matrix.directory }}: ${{ steps.minMax.outputs.maxVersion }}"
 
       - name: Install Terraform v${{ steps.minMax.outputs.minVersion }}
         uses: hashicorp/setup-terraform@v1
@@ -78,12 +78,12 @@ jobs:
         run: |
           pre-commit run generate_tf_providers -a
 
-      - name: Execute pre-commit min_version 1
+      - name: Execute pre-commit min_version for non root path
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory !=  '.' }}
         run: pre-commit run terraform_validate --color=always --show-diff-on-failure --files ${{ matrix.directory }}/*
 
-      - name: Execute pre-commit min_version 2
+      - name: Execute pre-commit min_version for root path
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory ==  '.' }}
         run: pre-commit run terraform_validate --color=always --show-diff-on-failure --files $(ls *.tf)

Gemfile

@@ -1,6 +1,6 @@
 source "https://rubygems.org/"
 
-gem "kitchen-terraform", "~> 6.0.0"
+gem "kitchen-terraform", "~> 6.1.0"
 #gem 'aws-sdk', '~> 3.0.1'
 #gem 'awspec', '~> 1.24.0'
 #gem 'kitchen-verifier-awspec', '~> 0.2.0'