Merge pull request #103 from vacantron/opt

jserv · web-flow · commit 83609c01036f · 2024-01-07T16:13:42.000+08:00
Implement CSE and peephole optimization
diff --git a/src/arm-codegen.c b/src/arm-codegen.c
@@ -151,9 +151,6 @@ void cfg_flatten()
 
             ph2_ir_t *insn;
             for (insn = bb->ph2_ir_list.head; insn; insn = insn->next) {
-                if (insn->op == OP_assign && insn->dest == insn->src0)
-                    continue;
-
                 flatten_ir = add_ph2_ir(OP_generic);
                 memcpy(flatten_ir, insn, sizeof(ph2_ir_t));
 
diff --git a/src/defs.h b/src/defs.h
@@ -18,7 +18,7 @@
 #define MAX_FIELDS 32
 #define MAX_FUNCS 256
 #define MAX_FUNC_TRIES 1950
-#define MAX_BLOCKS 1050
+#define MAX_BLOCKS 1150
 #define MAX_TYPES 64
 #define MAX_IR_INSTR 36864
 #define MAX_BB_PRED 128
@@ -299,6 +299,7 @@ typedef struct phi_operand phi_operand_t;
 
 struct insn {
     struct insn *next;
+    struct insn *prev;
     int idx;
     opcode_t opcode;
     var_t *rd;
diff --git a/src/globals.c b/src/globals.c
@@ -576,6 +576,7 @@ void add_insn(block_t *block,
     else
         bb->insn_list.tail->next = n;
 
+    n->prev = bb->insn_list.tail;
     bb->insn_list.tail = n;
 }
 
diff --git a/src/main.c b/src/main.c
@@ -33,6 +33,9 @@
 /* Register allocator */
 #include "reg-alloc.c"
 
+/* Peephole optimization */
+#include "peephole.c"
+
 /* Machine code generation. support ARMv7-A and RISC-V32I */
 #include "codegen.c"
 
@@ -83,12 +86,17 @@ int main(int argc, char *argv[])
 
     ssa_build(dump_ir);
 
+    /* SSA-based optimization */
+    optimize();
+
     /* SSA-based liveness analyses */
     liveness_analysis();
 
     /* allocate register from IR */
     reg_alloc();
 
+    peephole();
+
     /* flatten CFG to linear instruction */
     cfg_flatten();
 
diff --git a/src/peephole.c b/src/peephole.c
@@ -0,0 +1,73 @@
+/*
+ * shecc - Self-Hosting and Educational C Compiler.
+ *
+ * shecc is freely redistributable under the BSD 2 clause license. See the
+ * file "LICENSE" for information on usage and redistribution of this file.
+ */
+
+int is_fusible_insn(ph2_ir_t *ph2_ir)
+{
+    switch (ph2_ir->op) {
+    case OP_add:
+    case OP_sub:
+    case OP_mul:
+    case OP_div:
+    case OP_mod:
+    case OP_lshift:
+    case OP_rshift:
+    case OP_bit_and:
+    case OP_bit_or:
+    case OP_bit_xor:
+    case OP_log_and:
+    case OP_log_or:
+    case OP_log_not:
+    case OP_negate:
+    case OP_load:
+    case OP_global_load:
+    case OP_load_data_address:
+        return 1;
+    default:
+        return 0;
+    }
+}
+
+void insn_fusion(ph2_ir_t *ph2_ir)
+{
+    ph2_ir_t *next = ph2_ir->next;
+    if (!next)
+        return;
+
+    if (next->op == OP_assign) {
+        /* eliminate {ALU rn, rs1, rs2; mv rd, rn;} */
+        if (!is_fusible_insn(ph2_ir))
+            return;
+        if (ph2_ir->dest == next->src0) {
+            ph2_ir->dest = next->dest;
+            ph2_ir->next = next->next;
+            return;
+        }
+    }
+    /* other insn fusions */
+}
+
+/* FIXME: release detached basic blocks */
+void peephole()
+{
+    fn_t *fn;
+    for (fn = FUNC_LIST.head; fn; fn = fn->next) {
+        basic_block_t *bb;
+        for (bb = fn->bbs; bb; bb = bb->rpo_next) {
+            ph2_ir_t *ph2_ir;
+            for (ph2_ir = bb->ph2_ir_list.head; ph2_ir; ph2_ir = ph2_ir->next) {
+                ph2_ir_t *next = ph2_ir->next;
+                if (!next)
+                    continue;
+                if (next->op == OP_assign && next->dest == next->src0) {
+                    ph2_ir->next = next->next;
+                    continue;
+                }
+                insn_fusion(ph2_ir);
+            }
+        }
+    }
+}
diff --git a/src/reg-alloc.c b/src/reg-alloc.c
@@ -73,6 +73,17 @@ void spill_var(basic_block_t *bb, var_t *var, int idx)
     REGS[idx].polluted = 0;
 }
 
+/* Return the index of register for given variable. Otherwise, return -1. */
+int find_in_regs(var_t *var)
+{
+    int i;
+    for (i = 0; i < REG_CNT; i++) {
+        if (REGS[i].var == var)
+            return i;
+    }
+    return -1;
+}
+
 void load_var(basic_block_t *bb, var_t *var, int idx)
 {
     ph2_ir_t *ir = var->is_global ? bb_add_ph2_ir(bb, OP_global_load)
@@ -85,11 +96,9 @@ void load_var(basic_block_t *bb, var_t *var, int idx)
 
 int prepare_operand(basic_block_t *bb, var_t *var, int operand_0)
 {
-    int i;
-    for (i = 0; i < REG_CNT; i++) {
-        if (REGS[i].var == var)
-            return i;
-    }
+    int i = find_in_regs(var);
+    if (i > -1)
+        return i;
 
     for (i = 0; i < REG_CNT; i++) {
         if (!REGS[i].var) {
@@ -125,12 +134,11 @@ int prepare_operand(basic_block_t *bb, var_t *var, int operand_0)
 
 int prepare_dest(basic_block_t *bb, var_t *var, int operand_0, int operand_1)
 {
-    int i;
-    for (i = 0; i < REG_CNT; i++)
-        if (REGS[i].var == var) {
-            REGS[i].polluted = 1;
-            return i;
-        }
+    int i = find_in_regs(var);
+    if (i > -1) {
+        REGS[i].polluted = 1;
+        return i;
+    }
 
     for (i = 0; i < REG_CNT; i++) {
         if (!REGS[i].var) {
@@ -328,7 +336,7 @@ void reg_alloc()
                 func_t *func;
                 ph2_ir_t *ir;
                 int dest, src0, src1;
-                int i, sz;
+                int i, sz, clear_reg;
 
                 refresh(bb, insn);
 
@@ -404,9 +412,19 @@ void reg_alloc()
                     ir->dest = dest;
                     break;
                 case OP_assign:
-                    src0 = prepare_operand(bb, insn->rs1, -1);
+                    src0 = find_in_regs(insn->rs1);
+
+                    /* If operand is loaded from stack, clear the original slot
+                     * after moving.
+                     */
+                    if (src0 > -1)
+                        clear_reg = 0;
+                    else {
+                        clear_reg = 1;
+                        src0 = prepare_operand(bb, insn->rs1, -1);
+                    }
                     dest = prepare_dest(bb, insn->rd, src0, -1);
-                    ir = bb_add_ph2_ir(bb, insn->opcode);
+                    ir = bb_add_ph2_ir(bb, OP_assign);
                     ir->src0 = src0;
                     ir->dest = dest;
 
@@ -417,6 +435,10 @@ void reg_alloc()
                         ir->src1 = insn->rd->offset;
                         REGS[dest].polluted = 0;
                     }
+
+                    if (clear_reg)
+                        REGS[src0].var = NULL;
+
                     break;
                 case OP_read:
                     src0 = prepare_operand(bb, insn->rs1, -1);
diff --git a/src/riscv-codegen.c b/src/riscv-codegen.c
@@ -123,9 +123,6 @@ void cfg_flatten()
 
             ph2_ir_t *insn;
             for (insn = bb->ph2_ir_list.head; insn; insn = insn->next) {
-                if (insn->op == OP_assign && insn->dest == insn->src0)
-                    continue;
-
                 flatten_ir = add_ph2_ir(OP_generic);
                 memcpy(flatten_ir, insn, sizeof(ph2_ir_t));
 
@@ -146,6 +143,7 @@ void emit(int code)
 
 void emit_ph2_ir(ph2_ir_t *ph2_ir)
 {
+    func_t *func;
     int rd = ph2_ir->dest + 10;
     int rs1 = ph2_ir->src0 + 10;
     int rs2 = ph2_ir->src1 + 10;
@@ -249,16 +247,16 @@ void emit_ph2_ir(ph2_ir_t *ph2_ir)
         emit(__jal(__zero, ph2_ir->next_bb->elf_offset - elf_code_idx));
         return;
     case OP_call:
-        emit(__jal(__ra, find_func(ph2_ir->func_name)->fn->bbs->elf_offset -
-                             elf_code_idx));
+        func = find_func(ph2_ir->func_name);
+        emit(__jal(__ra, func->fn->bbs->elf_offset - elf_code_idx));
         return;
     case OP_load_data_address:
         emit(__lui(rd, rv_hi(elf_data_start + ph2_ir->src0)));
         emit(__addi(rd, rd, rv_lo(elf_data_start + ph2_ir->src0)));
         return;
     case OP_address_of_func:
-        ofs =
-            elf_code_start + find_func(ph2_ir->func_name)->fn->bbs->elf_offset;
+        func = find_func(ph2_ir->func_name);
+        ofs = elf_code_start + func->fn->bbs->elf_offset;
         emit(__lui(__t0, rv_hi(ofs)));
         emit(__addi(__t0, __t0, rv_lo(ofs)));
         emit(__sw(__t0, rs1, 0));
diff --git a/src/ssa.c b/src/ssa.c
@@ -651,18 +651,16 @@ void append_unwound_phi_insn(basic_block_t *bb, var_t *dest, var_t *rs)
     } else {
         /* insert it before branch instruction */
         if (tail->opcode == OP_branch) {
-            insn_t *prev = bb->insn_list.head;
-            if (!prev->next) {
+            if (tail->prev) {
+                tail->prev->next = n;
+                n->prev = tail->prev;
+            } else
                 bb->insn_list.head = n;
-                n->next = prev;
-            } else {
-                while (prev->next != tail)
-                    prev = prev->next;
-                prev->next = n;
-                n->next = tail;
-            }
+
+            n->next = tail;
+            tail->prev = n;
         } else {
-            bb->insn_list.tail->next = n;
+            tail->next = n;
             bb->insn_list.tail = n;
         }
     }
@@ -1051,6 +1049,84 @@ void ssa_build(int dump_ir)
     unwind_phi();
 }
 
+/* Common Subexpression Elimination (CSE) */
+/* TODO: simplify with def-use chain */
+/* TODO: release detached insns node */
+int cse(insn_t *insn, basic_block_t *bb)
+{
+    if (insn->opcode != OP_read)
+        return 0;
+
+    insn_t *prev = insn->prev;
+
+    if (!prev)
+        return 0;
+    if (prev->opcode != OP_add)
+        return 0;
+    if (prev->rd != insn->rs1)
+        return 0;
+
+    var_t *def = NULL, *base = prev->rs1, *idx = prev->rs2;
+    basic_block_t *b;
+    insn_t *i = prev;
+    for (b = bb;; b = b->idom) {
+        if (!i)
+            i = b->insn_list.tail;
+
+        for (; i; i = i->prev) {
+            if (i == prev)
+                continue;
+            if (i->opcode != OP_add)
+                continue;
+            if (!i->next)
+                continue;
+            if (i->next->opcode != OP_read)
+                continue;
+            if (i->rs1 != base || i->rs2 != idx)
+                continue;
+            def = i->next->rd;
+        }
+        if (def)
+            break;
+        if (b->idom == b)
+            break;
+    }
+
+    if (!def)
+        return 0;
+
+    if (prev->prev) {
+        insn->prev = prev->prev;
+        prev->next = insn;
+    } else {
+        bb->insn_list.head = insn;
+        insn->prev = NULL;
+    }
+
+    insn->opcode = OP_assign;
+    insn->rs1 = def;
+    return 1;
+}
+
+void optimize()
+{
+    int changed = 0;
+    fn_t *fn;
+    for (fn = FUNC_LIST.head; fn; fn = fn->next) {
+        /* basic block level (control flow) optimizations */
+
+        basic_block_t *bb;
+        for (bb = fn->bbs; bb; bb = bb->rpo_next) {
+            /* instruction level optimizations */
+            insn_t *insn;
+            for (insn = bb->insn_list.head; insn; insn = insn->next) {
+                changed |= cse(insn, bb);
+                /* more optimizations */
+            }
+        }
+    }
+}
+
 void bb_index_reversed_rpo(fn_t *fn, basic_block_t *bb)
 {
     bb->rpo_r = fn->bb_cnt++;

Original file line number	Diff line number	Diff line change
`@@ -576,6 +576,7 @@ void add_insn(block_t *block,`
`576`	`576`	`else`
`577`	`577`	`bb->insn_list.tail->next = n;`
`578`	`578`
	`579`	`+ n->prev = bb->insn_list.tail;`
`579`	`580`	`bb->insn_list.tail = n;`
`580`	`581`	`}`
`581`	`582`