Skip to content

Commit

Permalink
Support PHP 8.0
Browse files Browse the repository at this point in the history
  • Loading branch information
szepeviktor committed Oct 27, 2020
1 parent a5addc6 commit 82f4d40
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,21 @@ Please see [WooCommerce Stubs](https://github.com/php-stubs/woocommerce-stubs)
- Write clean OOP code: 1 class per file, no other code in class files outside `class Name { ... }`
- Structure your code: uniform class names (WPCS or PSR-4), keep classes in a separate directory `inc/`
- Add proper PHPDoc blocks to classes, properties, methods, functions
- Handle these only in your [main plugin file](https://github.com/kingkero/wordpress-demoplugin/blob/master/wordpress-demoplugin.php),
another [main plugin file](https://github.com/pryley/site-reviews/blob/v5.0.1/site-reviews.php) example
- Handle these only in your [main plugin file](https://github.com/kingkero/wordpress-demoplugin/blob/master/wordpress-demoplugin.php).
Here is another [main plugin file](https://github.com/pryley/site-reviews/blob/v5.0.1/site-reviews.php) example.
- Define constants, e.g. `MYPLUGIN_PATH`
- Call `register_activation_hook()`, `register_deactivation_hook()`, `register_uninstall_hook()`
- Class autoloading
- Load class autoloader
- Load translations
- Support WP-CLI
- Decide [what to load](https://github.com/szepeviktor/Toolkit4WP/blob/master/src/Is.php#L64-L73)
- Start your plugin in a hook (`plugins_loaded`) - without direct execution
- Avoid using core constants, use core functions or `MYPLUGIN_PATH`
- Avoid bad parts of PHP
- functions: eval, extract, compact, list
- functions: `eval`, `extract`, `compact`, `list`
- [type juggling](https://www.php.net/manual/en/language.types.type-juggling.php): `$a = '15'; if ($a) ...`
- If you need robust code try avoiding all kinds of type casting (e.g. `if` needs a boolean),
- If you need robust code try avoiding all kinds of type juggling (e.g. `if` needs a boolean),
see [Variable handling functions](https://www.php.net/manual/en/ref.var.php)
- If you are not bound by PHP 5.x consider following
- If you are not bound by PHP 5 consider following
[Neutron Standard](https://github.com/Automattic/phpcs-neutron-standard)
- Do not enable `exit_error` in `WP_CLI::launch` or `WP_CLI::runcommand` to keep your code testable
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"license": "MIT",
"require": {
"php": "~7.1",
"php": "^7.1 || ^8.0",
"php-stubs/wordpress-stubs": "^4.7 || ^5.0",
"phpstan/phpstan": "^0.12.26",
"symfony/polyfill-php73": "^1.12.0"
Expand Down

0 comments on commit 82f4d40

Please sign in to comment.