Skip to content

Commit e6e3e89

Browse files
authored
Add type declarations to properties (#254)
1 parent 3ffad20 commit e6e3e89

8 files changed

+17
-28
lines changed

src/ApplyFiltersDynamicFunctionReturnTypeExtension.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
class ApplyFiltersDynamicFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
1818
{
19-
/** @var \SzepeViktor\PHPStan\WordPress\HookDocBlock */
20-
protected $hookDocBlock;
19+
protected HookDocBlock $hookDocBlock;
2120

2221
public function __construct(HookDocBlock $hookDocBlock)
2322
{

src/AssertNotWpErrorTypeSpecifyingExtension.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919

2020
class AssertNotWpErrorTypeSpecifyingExtension implements \PHPStan\Type\MethodTypeSpecifyingExtension, \PHPStan\Analyser\TypeSpecifierAwareExtension
2121
{
22-
/** @var \PHPStan\Analyser\TypeSpecifier */
23-
private $typeSpecifier;
22+
private TypeSpecifier $typeSpecifier;
2423

2524
public function getClass(): string
2625
{

src/AssertWpErrorTypeSpecifyingExtension.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818

1919
class AssertWpErrorTypeSpecifyingExtension implements \PHPStan\Type\MethodTypeSpecifyingExtension, \PHPStan\Analyser\TypeSpecifierAwareExtension
2020
{
21-
/** @var \PHPStan\Analyser\TypeSpecifier */
22-
private $typeSpecifier;
21+
private TypeSpecifier $typeSpecifier;
2322

2423
public function getClass(): string
2524
{

src/HookCallbackRule.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,9 @@ class HookCallbackRule implements \PHPStan\Rules\Rule
3838
private const ACCEPTED_ARGS_DEFAULT = 1;
3939

4040
/** @var list<\PHPStan\Rules\IdentifierRuleError> */
41-
private $errors;
41+
private array $errors;
4242

43-
/** @var \PHPStan\Analyser\Scope */
44-
protected $currentScope;
43+
protected Scope $currentScope;
4544

4645
public function getNodeType(): string
4746
{

src/HookDocBlock.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515

1616
class HookDocBlock
1717
{
18-
/** @var \PHPStan\Type\FileTypeMapper */
19-
protected $fileTypeMapper;
18+
protected FileTypeMapper $fileTypeMapper;
2019

2120
public function __construct(FileTypeMapper $fileTypeMapper)
2221
{

src/HookDocsRule.php

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,16 @@ class HookDocsRule implements \PHPStan\Rules\Rule
3131
'do_action',
3232
];
3333

34-
/** @var \SzepeViktor\PHPStan\WordPress\HookDocBlock */
35-
protected $hookDocBlock;
34+
protected HookDocBlock $hookDocBlock;
3635

37-
/** @var \PHPStan\Rules\RuleLevelHelper */
38-
protected $ruleLevelHelper;
36+
protected RuleLevelHelper $ruleLevelHelper;
3937

40-
/** @var \PhpParser\Node\Expr\FuncCall */
41-
protected $currentNode;
38+
protected FuncCall $currentNode;
4239

43-
/** @var \PHPStan\Analyser\Scope */
44-
protected $currentScope;
40+
protected Scope $currentScope;
4541

4642
/** @var list<\PHPStan\Rules\IdentifierRuleError> */
47-
private $errors;
43+
private array $errors;
4844

4945
public function __construct(
5046
FileTypeMapper $fileTypeMapper,

src/HookDocsVisitor.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88

99
namespace SzepeViktor\PHPStan\WordPress;
1010

11+
use PhpParser\Comment\Doc;
1112
use PhpParser\Node;
1213

1314
final class HookDocsVisitor extends \PhpParser\NodeVisitorAbstract
1415
{
15-
/** @var int|null */
16-
protected $latestStartLine = null;
16+
protected ?int $latestStartLine;
1717

18-
/** @var \PhpParser\Comment\Doc|null */
19-
protected $latestDocComment = null;
18+
protected ?Doc $latestDocComment;
2019

2120
// phpcs:ignore SlevomatCodingStandard.Functions.UnusedParameter
2221
public function beforeTraverse(array $nodes): ?array

src/WpParseUrlFunctionDynamicReturnTypeExtension.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,12 @@
4040
final class WpParseUrlFunctionDynamicReturnTypeExtension implements \PHPStan\Type\DynamicFunctionReturnTypeExtension
4141
{
4242
/** @var array<int, \PHPStan\Type\Type>|null */
43-
private $componentTypesPairedConstants = null;
43+
private ?array $componentTypesPairedConstants = null;
4444

4545
/** @var array<string, \PHPStan\Type\Type>|null */
46-
private $componentTypesPairedStrings = null;
46+
private ?array $componentTypesPairedStrings = null;
4747

48-
/** @var \PHPStan\Type\Type|null */
49-
private $allComponentsTogetherType = null;
48+
private ?Type $allComponentsTogetherType = null;
5049

5150
public function isFunctionSupported(FunctionReflection $functionReflection): bool
5251
{

0 commit comments

Comments
 (0)