Merge pull request #128 from tomoyukikashiro/fix/type-attr-in-source

fix(picture): remove type attribute in source tag

Author: t-jindai

lib/utils.js

@@ -62,9 +62,8 @@ const srcNode = async (cwd, attributes) => {
     size = { width: result.width, height: result.height }
     fileStream.destroy()
   }
-  // remove loading attribute
-  // https://github.com/tomoyukikashiro/html2amp/issues/80
-  let { loading, ..._attrs } = attrs
+  // remove loading, type attributes (#80, #104)
+  let { loading, type, ..._attrs } = attrs
   _attrs = { src: url, alt, width: size.width, height: size.height, layout: 'responsive', ..._attrs }
   const _attrsStr = Object.keys(_attrs).map(key => `${key}="${_attrs[key]}"`).join(' ')
   return `<amp-img ${_attrsStr}></amp-img>`

test/picture.test.js

@@ -17,7 +17,7 @@ describe('picture', () => {
     const html = htmlFactory({ body: str })
     it('should be replaced with custom img tag', async () => {
       const $ = await picture(cheerio.load(html))
-      const expectedTag = '<amp-img src="http://dummyimage.com/100x200/000/fff.png" alt="test" width="100" height="200" layout="responsive" type="image/png" srcset="http://dummyimage.com/100x200/000/fff.png 1x, http://dummyimage.com/200x400/000/fff.png 2x"><amp-img src="http://dummyimage.com/100x200/000/fff.jpg" alt="test" width="100" height="200" layout="responsive" type="image/jpg" srcset="http://dummyimage.com/100x200/000/fff.jpg 1x, http://dummyimage.com/200x400/000/fff.jpg 2x"></amp-img><amp-img src="http://dummyimage.com/200x400/000/fff.jpg" alt="test" width="200" height="400" layout="responsive" fallback=""></amp-img></amp-img>'
+      const expectedTag = '<amp-img src="http://dummyimage.com/100x200/000/fff.png" alt="test" width="100" height="200" layout="responsive" srcset="http://dummyimage.com/100x200/000/fff.png 1x, http://dummyimage.com/200x400/000/fff.png 2x"><amp-img src="http://dummyimage.com/100x200/000/fff.jpg" alt="test" width="100" height="200" layout="responsive" srcset="http://dummyimage.com/100x200/000/fff.jpg 1x, http://dummyimage.com/200x400/000/fff.jpg 2x"></amp-img><amp-img src="http://dummyimage.com/200x400/000/fff.jpg" alt="test" width="200" height="400" layout="responsive" fallback=""></amp-img></amp-img>'
       const expected = htmlFactory({ body: expectedTag })
       assert($, expected)
     })