Skip to content

Commit 11941bc

Browse files
committed
fix: assert on warning instead of ignore
1 parent 518d495 commit 11941bc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/test_user.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -243,23 +243,23 @@ def test_populate_groups(self) -> None:
243243
self.assertEqual("TableauExample", group_list[2].name)
244244
self.assertEqual("local", group_list[2].domain_name)
245245

246-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
247246
def test_get_usernames_from_file(self):
248247
with open(ADD_XML, "rb") as f:
249248
response_xml = f.read().decode("utf-8")
250249
with requests_mock.mock() as m:
251250
m.post(self.server.users.baseurl, text=response_xml)
252-
user_list, failures = self.server.users.create_from_file(USERNAMES)
251+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
252+
user_list, failures = self.server.users.create_from_file(USERNAMES)
253253
assert user_list[0].name == "Cassie", user_list
254254
assert failures == [], failures
255255

256-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
257256
def test_get_users_from_file(self):
258257
with open(ADD_XML, "rb") as f:
259258
response_xml = f.read().decode("utf-8")
260259
with requests_mock.mock() as m:
261260
m.post(self.server.users.baseurl, text=response_xml)
262-
users, failures = self.server.users.create_from_file(USERS)
261+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
262+
users, failures = self.server.users.create_from_file(USERS)
263263
assert users[0].name == "Cassie", users
264264
assert failures == []
265265

0 commit comments

Comments
 (0)