Skip to content

Commit 9ce8b50

Browse files
committed
fix: assert on warning instead of ignore
1 parent fd877e5 commit 9ce8b50

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/test_user.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -245,23 +245,23 @@ def test_populate_groups(self) -> None:
245245
self.assertEqual("TableauExample", group_list[2].name)
246246
self.assertEqual("local", group_list[2].domain_name)
247247

248-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
249248
def test_get_usernames_from_file(self):
250249
with open(ADD_XML, "rb") as f:
251250
response_xml = f.read().decode("utf-8")
252251
with requests_mock.mock() as m:
253252
m.post(self.server.users.baseurl, text=response_xml)
254-
user_list, failures = self.server.users.create_from_file(USERNAMES)
253+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
254+
user_list, failures = self.server.users.create_from_file(USERNAMES)
255255
assert user_list[0].name == "Cassie", user_list
256256
assert failures == [], failures
257257

258-
@pytest.mark.filterwarnings("ignore:This method is deprecated, use bulk_add instead")
259258
def test_get_users_from_file(self):
260259
with open(ADD_XML, "rb") as f:
261260
response_xml = f.read().decode("utf-8")
262261
with requests_mock.mock() as m:
263262
m.post(self.server.users.baseurl, text=response_xml)
264-
users, failures = self.server.users.create_from_file(USERS)
263+
with pytest.warns(DeprecationWarning, match="This method is deprecated, use bulk_add instead"):
264+
users, failures = self.server.users.create_from_file(USERS)
265265
assert users[0].name == "Cassie", users
266266
assert failures == []
267267

0 commit comments

Comments
 (0)