Merge pull request #732 from Mingun/fix-warnings

Fix warnings reported by new rustc

Author: Mingun

examples/read_nodes.rs

@@ -30,6 +30,8 @@ const XML: &str = r#"
   </Localization>
 "#;
 
+// Enum variants is not read in example, so suppress the warning
+#[allow(dead_code)]
 #[derive(Debug)]
 enum AppError {
     /// XML parsing error

src/de/simple_type.rs

@@ -11,7 +11,7 @@ use crate::utils::CowRef;
 use memchr::memchr;
 use serde::de::value::UnitDeserializer;
 use serde::de::{DeserializeSeed, Deserializer, EnumAccess, SeqAccess, VariantAccess, Visitor};
-use serde::{self, serde_if_integer128};
+use serde::serde_if_integer128;
 use std::borrow::Cow;
 use std::ops::Range;
 

src/errors.rs

@@ -308,7 +308,6 @@ pub mod serialize {
     //! A module to handle serde (de)serialization errors
 
     use super::*;
-    use crate::utils::write_byte_string;
     use std::borrow::Cow;
     #[cfg(feature = "overlapped-lists")]
     use std::num::NonZeroUsize;

src/name.rs

@@ -8,7 +8,6 @@ use crate::events::attributes::Attribute;
 use crate::events::BytesStart;
 use crate::utils::write_byte_string;
 use memchr::memchr;
-use std::convert::TryFrom;
 use std::fmt::{self, Debug, Formatter};
 
 /// A [qualified name] of an element or an attribute, including an optional

src/reader/buffered_reader.rs

@@ -5,8 +5,6 @@ use std::fs::File;
 use std::io::{self, BufRead, BufReader};
 use std::path::Path;
 
-use memchr;
-
 use crate::errors::{Error, Result, SyntaxError};
 use crate::events::Event;
 use crate::name::QName;
@@ -233,7 +231,11 @@ macro_rules! impl_buffered_source {
     };
 }
 
-// Make it public for use in async implementations
+// Make it public for use in async implementations.
+// New rustc reports
+// > warning: the item `impl_buffered_source` is imported redundantly
+// so make it public only when async feature is enabled
+#[cfg(feature = "async-tokio")]
 pub(super) use impl_buffered_source;
 
 /// Implementation of `XmlSource` for any `BufRead` reader using a user-given

src/reader/mod.rs

@@ -9,8 +9,6 @@ use crate::errors::{Error, Result, SyntaxError};
 use crate::events::Event;
 use crate::reader::state::ReaderState;
 
-use memchr;
-
 /// A struct that holds a parser configuration.
 ///
 /// Current parser configuration can be retrieved by calling [`Reader::config()`]

src/reader/slice_reader.rs

@@ -14,8 +14,6 @@ use crate::events::Event;
 use crate::name::QName;
 use crate::reader::{is_whitespace, BangType, ReadElementState, Reader, Span, XmlSource};
 
-use memchr;
-
 /// This is an implementation for reading from a `&[u8]` as underlying byte stream.
 /// This implementation supports not using an intermediate buffer as the byte slice
 /// itself can be used to borrow from.

src/reader/state.rs

@@ -8,8 +8,6 @@ use crate::events::{BytesCData, BytesDecl, BytesEnd, BytesStart, BytesText, Even
 use crate::reader::EncodingRef;
 use crate::reader::{is_whitespace, BangType, Config, ParseState};
 
-use memchr;
-
 /// A struct that holds a current reader state and a parser configuration.
 /// It is independent on a way of reading data: the reader feed data into it and
 /// get back produced [`Event`]s.