fix(taiko-client): fix bug about nil interface check (#18886)

mask-pp · web-flow · commit 645f0a005683 · 2025-02-07T14:59:11.000+08:00
diff --git a/packages/taiko-client/pkg/utils/txmgr_selector.go b/packages/taiko-client/pkg/utils/txmgr_selector.go
@@ -4,6 +4,7 @@ import (
 	"time"
 
 	"github.com/ethereum-optimism/optimism/op-service/txmgr"
+	"github.com/modern-go/reflect2"
 )
 
 var (
@@ -42,7 +43,7 @@ func NewTxMgrSelector(
 // Select selects a transaction manager based on the current state.
 func (s *TxMgrSelector) Select() (txmgr.TxManager, bool) {
 	// If there is no private transaction manager, return the normal transaction manager.
-	if s.privateTxMgr == nil {
+	if reflect2.IsNil(s.privateTxMgr) {
 		return s.txMgr, false
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import (`
`4`	`4`	`"time"`
`5`	`5`
`6`	`6`	`"github.com/ethereum-optimism/optimism/op-service/txmgr"`
	`7`	`+ "github.com/modern-go/reflect2"`
`7`	`8`	`)`
`8`	`9`
`9`	`10`	`var (`
`@@ -42,7 +43,7 @@ func NewTxMgrSelector(`
`42`	`43`	`// Select selects a transaction manager based on the current state.`
`43`	`44`	`func (s *TxMgrSelector) Select() (txmgr.TxManager, bool) {`
`44`	`45`	`// If there is no private transaction manager, return the normal transaction manager.`
`45`		`- if s.privateTxMgr == nil {`
	`46`	`+ if reflect2.IsNil(s.privateTxMgr) {`
`46`	`47`	`return s.txMgr, false`
`47`	`48`	`}`
`48`	`49`