From 7d6fc8768d52b06d0a00ff3cc8a692dc225df158 Mon Sep 17 00:00:00 2001 From: David Date: Wed, 22 Jan 2025 14:33:29 +0800 Subject: [PATCH] feat: update comments --- packages/taiko-client/proposer/transaction_builder/blob.go | 6 +++--- .../taiko-client/proposer/transaction_builder/fallback.go | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/taiko-client/proposer/transaction_builder/blob.go b/packages/taiko-client/proposer/transaction_builder/blob.go index 9d41f9ab468..2a73fdd8211 100644 --- a/packages/taiko-client/proposer/transaction_builder/blob.go +++ b/packages/taiko-client/proposer/transaction_builder/blob.go @@ -8,6 +8,7 @@ import ( "github.com/ethereum-optimism/optimism/op-service/eth" "github.com/ethereum-optimism/optimism/op-service/txmgr" + "github.com/ethereum/go-ethereum/accounts/abi/bind" "github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/core/types" "github.com/ethereum/go-ethereum/rlp" @@ -61,13 +62,12 @@ func (b *BlobTransactionBuilder) BuildOntake( txListBytesArray [][]byte, ) (*txmgr.TxCandidate, error) { // Check if the current L2 chain is after ontake fork. - // TODO: query from protocol. - l2Head, err := b.rpc.L2.BlockNumber(ctx) + _, slotB, err := b.rpc.GetProtocolStateVariablesOntake(&bind.CallOpts{Context: ctx}) if err != nil { return nil, err } - if !b.chainConfig.IsOntake(new(big.Int).SetUint64(l2Head)) { + if !b.chainConfig.IsOntake(new(big.Int).SetUint64(slotB.NumBlocks)) { return nil, fmt.Errorf("ontake transaction builder is not supported before ontake fork") } diff --git a/packages/taiko-client/proposer/transaction_builder/fallback.go b/packages/taiko-client/proposer/transaction_builder/fallback.go index 4a9b7810bfd..48905169294 100644 --- a/packages/taiko-client/proposer/transaction_builder/fallback.go +++ b/packages/taiko-client/proposer/transaction_builder/fallback.go @@ -150,7 +150,6 @@ func (b *TxBuilderWithFallback) BuildOntake( } // BuildPacaya implements the ProposeBlocksTransactionBuilder interface. -// TODO: improve this method to use func interface. func (b *TxBuilderWithFallback) BuildPacaya( ctx context.Context, txBatch []types.Transactions,