Merge pull request #16 from yasharsanaei/angular-17-fix

Angular 17 fix

Author: sindorei1993

.eslintrc.js

@@ -10,7 +10,7 @@ module.exports = {
         createDefaultProgram: false,
       },
       plugins: [/*'rxjs',*/ 'sonarjs', 'unused-imports'],
-      extends: ['plugin:sonarjs/recommended', 'plugin:@angular-eslint/recommended', 'prettier'],
+      extends: ['plugin:@typescript-eslint/recommended', 'plugin:sonarjs/recommended', 'plugin:@angular-eslint/recommended', 'prettier'],
       rules: {
         // Eslint
         'no-negated-in-lhs': 'error',
@@ -28,7 +28,7 @@ module.exports = {
         'no-cond-assign': 'error',
         'no-empty': 'warn',
         'no-redeclare': 'warn',
-        // 'class-methods-use-this': 'warn', // This is producing a lot of warnings that aren't really important.
+        'class-methods-use-this': 'off', // This is producing a lot of warnings that aren't really important.
         'prefer-const': 'warn',
         'no-console': ['error', { allow: ['error', 'warn'] }],
         eqeqeq: ['warn', 'smart'],
@@ -39,7 +39,7 @@ module.exports = {
             paths: [
               {
                 name: 'rxjs/Rx',
-                message: "Please import directly from 'rxjs' instead",
+                message: 'Please import directly from \'rxjs\' instead',
               },
             ],
             patterns: ['../../*'],
@@ -62,6 +62,12 @@ module.exports = {
           'warn',
           { vars: 'all', varsIgnorePattern: '^_', args: 'after-used', argsIgnorePattern: '^_' },
         ],
+        '@typescript-eslint/no-unsafe-call': 'warn',
+        '@typescript-eslint/no-unsafe-member-access': 'warn', // This is producing a lot of warnings that aren't really important.
+        '@typescript-eslint/no-unsafe-return': 'warn',
+        '@typescript-eslint/no-unnecessary-condition': 'off', // TODO: uncomment when all projects are strict:true
+        '@typescript-eslint/no-explicit-any': 'warn',
+        '@typescript-eslint/prefer-nullish-coalescing': 'warn',
       },
     },
   ],

lib/configs/angular.js

@@ -10,7 +10,12 @@ module.exports = {
         createDefaultProgram: false,
       },
       plugins: [/*'rxjs',*/ 'sonarjs', '@tapsellorg', 'unused-imports'],
-      extends: ['plugin:sonarjs/recommended', 'plugin:@angular-eslint/recommended', 'prettier'],
+      extends: [
+        'plugin:sonarjs/recommended',
+        'plugin:@angular-eslint/recommended',
+        'plugin:@typescript-eslint/recommended',
+        'prettier',
+      ],
       rules: {
         // Eslint
         'no-negated-in-lhs': 'error',
@@ -28,7 +33,7 @@ module.exports = {
         'no-cond-assign': 'error',
         'no-empty': 'warn',
         'no-redeclare': 'warn',
-        // 'class-methods-use-this': 'warn', // This is producing a lot of warnings that aren't really important.
+        'class-methods-use-this': 'off', // This is producing a lot of warnings that aren't really important.
         'prefer-const': 'warn',
         'no-console': ['error', { allow: ['error', 'warn', 'assert'] }],
         eqeqeq: ['warn', 'smart'],
@@ -82,11 +87,9 @@ module.exports = {
         '@typescript-eslint/array-type': ['warn', { default: 'array' }],
         '@typescript-eslint/no-this-alias': 'warn',
         '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'warn',
-        // '@typescript-eslint/no-unnecessary-condition': 'warn', // TODO: uncomment when all projects are strict:true
-        // '@typescript-eslint/no-unsafe-member-access': 'warn', // This is producing a lot of warnings that aren't really important.
         '@typescript-eslint/prefer-includes': 'error',
         '@typescript-eslint/prefer-as-const': 'warn',
-        '@typescript-eslint/prefer-nullish-coalescing': 'warn',
+        'prefer-optional-chain': 'off',
         '@typescript-eslint/prefer-optional-chain': 'warn',
         '@typescript-eslint/prefer-reduce-type-parameter': 'warn',
         // angular eslint
@@ -102,6 +105,26 @@ module.exports = {
           'warn',
           { vars: 'all', varsIgnorePattern: '^_', args: 'after-used', argsIgnorePattern: '^_' },
         ],
+        '@typescript-eslint/prefer-nullish-coalescing': 'warn',
+        '@typescript-eslint/no-unnecessary-condition': 'off', // TODO: uncomment when all projects are strict:true
+        '@typescript-eslint/no-unsafe-member-access': 'warn', // This is producing a lot of warnings that aren't really important.
+        '@typescript-eslint/no-unsafe-return': 'warn',
+        '@typescript-eslint/no-unsafe-assignment': 'warn',
+        '@typescript-eslint/no-unsafe-argument': 'warn',
+        '@typescript-eslint/no-unsafe-call': 'warn',
+        'prefer-rest-params': 'off',
+        '@typescript-eslint/ban-types': 'off',
+        '@typescript-eslint/no-explicit-any': 'warn',
+        '@typescript-eslint/no-unnecessary-type-constraint': 'warn',
+        '@typescript-eslint/consistent-indexed-object-style': 'warn',
+        '@typescript-eslint/no-var-requires': 'warn',
+        '@typescript-eslint/no-extraneous-class': [
+          'warn',
+          {
+            allowConstructorOnly: true,
+            allowEmpty: true,
+          },
+        ],
       },
     },
     {

lib/index.ts

@@ -0,0 +1,17 @@
+/**
+ * @fileoverview Tapsell custom eslint plugin
+ * @author Vahid Mohammadi
+ */
+
+import angular from './configs/angular';
+
+//------------------------------------------------------------------------------
+// Plugin Definition
+//------------------------------------------------------------------------------
+
+// import all rules in lib/rules
+module.exports = {
+  configs: {
+    angular,
+  },
+};