File tree 2 files changed +14
-0
lines changed
2 files changed +14
-0
lines changed Original file line number Diff line number Diff line change @@ -2140,6 +2140,7 @@ sub process {
2140
2140
2141
2141
my %commit_log_tags = ();
2142
2142
my $has_changelog = 0;
2143
+ my $warned_about_test_result_file = 0;
2143
2144
my $has_doc = 0;
2144
2145
my $has_test = 0;
2145
2146
my $is_test = 0;
@@ -2823,6 +2824,14 @@ sub process {
2823
2824
" please, use spaces instead of tabs\n " . $herevet );
2824
2825
}
2825
2826
2827
+ if (!$warned_about_test_result_file &&
2828
+ $realfile =~ / ^test\/ .*\. result$ / &&
2829
+ $line =~ / ^\+ / ) {
2830
+ $warned_about_test_result_file = 1;
2831
+ ERROR(" TEST_RESULT_FILE" ,
2832
+ " Please avoid tests with .result files\n " );
2833
+ }
2834
+
2826
2835
# check we are in a valid C source file if not then ignore this hunk
2827
2836
next if ($realfile !~ / \. (h|c|cc)$ / );
2828
2837
Original file line number Diff line number Diff line change @@ -774,6 +774,11 @@ Others
774
774
**PRINTF_0XDECIMAL **
775
775
Prefixing 0x with decimal output is defective and should be corrected.
776
776
777
+ **TEST_RESULT_FILE **
778
+ For regression tests, there are .result files. Tests with .result files
779
+ should be avoided. It is recommended to use Luatest or TAP for Tarantool
780
+ regression tests.
781
+
777
782
**TYPO_SPELLING **
778
783
Some words may have been misspelled. Consider reviewing them.
779
784
You can’t perform that action at this time.
0 commit comments