iproto: add missing IPROTO feature flags to greeting negotiation #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
approved these changes
Oct 29, 2025
oleg-jukovec
requested changes
Oct 29, 2025
There was a problem hiding this comment.
Please, squash the commits:
iproto: add missing IPROTO feature flags to greeting negotiation
The flags of functions IPROTO_FEATURE_IS_SYNC and IPROTO_FEATURE_INSERT_ARROW protocol function flags were added in the welcome, fixed tests that test for flags by adding a byte sequence.
Fixed https://github.com/tarantool/go-tarantool/issues/466
iproto: add missing IPROTO feature flags to greeting negotiation
The flags of functions IPROTO_FEATURE_IS_SYNC and IPROTO_FEATURE_INSERT_ARROW protocol function flags were added in the welcome, fixed tests that test for flags by adding a byte sequence.
Added https://github.com/tarantool/go-tarantool/issues/466
->
iproto: add missing IPROTO greeting flags
The greeting flags of functions IPROTO_FEATURE_IS_SYNC and
IPROTO_FEATURE_INSERT_ARROW protocol function flags were added.
Closes #466
Into a single-well written commit according to the rules:
babyTsakhes
force-pushed
the
babyTsakhes/gh-466-add-missing-IPROTO-feature-flags
branch
from
176ad4e to
fde83ae
Compare
The greeting flags of functions IPROTO_FEATURE_IS_SYNC and IPROTO_FEATURE_INSERT_ARROW protocol function flags were added. Closes #466
babyTsakhes
force-pushed
the
babyTsakhes/gh-466-add-missing-IPROTO-feature-flags
branch
from
fde83ae to
927276c
Compare
oleg-jukovec
approved these changes
Oct 31, 2025
oleg-jukovec
deleted the
babyTsakhes/gh-466-add-missing-IPROTO-feature-flags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added #466