Skip to content

Timeout doesn't work for RouterCallImpl #15

@nurzhan-saktaganov

Description

@nurzhan-saktaganov

Original: KaymeKaydex/go-vshard-router#74

Since we don't set a timeout for Tarantool.NewCallRequest using context.WithTimeout, a timeout for RouterCallImpl doesn't apply.

Also, we should inspect other functions for this bug.

UPD 19.12.2024: Timeout for RouterCallImpl will be fixed by KaymeKaydex/go-vshard-router#111

Check (add autotest), fix or add comment about how timeout works for these methods:

api.go
    - RouterCallImpl
    - RouterMapCallRWImpl
discovery.go
    - BucketDiscovery(aliases RouterRoute, BucketResolve)
    - DiscoveryAllBuckets
replicaset.go
    - BucketStat
    - ReplicaCall
    - CallAsync
    - BucketsCount
    - BucketForceCreate
sugar.go
    - Do
topology.go
    - AddInstance
    - AddReplicaset
    - RemoveReplicaset
vshard.go
    - NewRouter
    - ClusterBootstrap

Metadata

Metadata

Assignees

No one assigned

    Labels

    code healthImprove code readability, simplify maintenance and so on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions