Skip to content

VERSION always unknown #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theonedemon opened this issue May 29, 2020 · 3 comments
Open

VERSION always unknown #124

theonedemon opened this issue May 29, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@theonedemon
Copy link

local VERSION = 'unknown'
if package.search('http.VERSION') then
    VERSION = require('http.VERSION')
end

file VERSION.lua contains in .gitignore and always build package has "unknown" version

@ligurio
Copy link
Member

ligurio commented Nov 10, 2021

issue is related to http-v2 that is now deprecated.

@Totktonada
Copy link
Member

We can implement the similar mechanism for http v1 too, if it is useful. Personally I several times meet the situation, when a user answers "I don't know" for "which version of a module is installed on your system?".

Brief checklist (for a module with Lua/C, pure Lua would differ a bit):

  • Correct version in a module installed using tarantoolctl rocks install <module> <version> (from rockspec as well as from src.rock).
  • The same for scm-1 (only rockspec).
  • The same for tarantoolctl rocks make in a git repository.
  • The same for cmake . && make build.
  • The same for RPM / Deb packages.

(Am I missed something?)

@LeonidVas LeonidVas added teamE and removed http-v2 labels Dec 23, 2021
@Totktonada Totktonada added the bug Something isn't working label Dec 23, 2021
@DifferentialOrange
Copy link
Member

Isn't it solved by #184?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants