Skip to content

Commit 19bb1a0

Browse files
msgpack: support datetime extended type
Tarantool supports datetime type since version 2.10.0 [1]. This patch introduced the support of Tarantool datetime type in msgpack decoders and encoders. The Tarantool datetime type is mapped to new tarantool.Datetime type which inherits pandas.Timestamp [2]. pandas.Timestamp was chosen as a base class because it could be used to store both nanoseconds and timezone information. In-build Python datetime.datetime supports microseconds at most, numpy.datetime64 do not support timezones. There are two reasons to use custom type instead of plain pandas.Timestamp: - tzindex may be lost on conversion to pandas.Timestamp - Tarantool datetime interval type is planned to be stored in custom type tarantool.Interval and we'll need a way to support arithmetic between datetime and interval. msgpack encoder supports encoding pandas.Timestamp with tarantool.Datetime tools, but it always decodes to tarantool.Datetime. If you plan to work with tarantool datetimes, please stick to the tarantool.Datetime object rather than pure pandas.Timestamp. You can create tarantool.Datetime from pandas.Timestamp or by using the same API as in plain pandas.Timestamp. If you used numpy.datetime64 or datetime.datetime in your logic, you can use pandas.to_datetime64() and pandas.to_datetime() converters. This patch does not yet introduce the support of timezones in datetime. 1. tarantool/tarantool#5941 2. https://pandas.pydata.org/docs/reference/api/pandas.Timestamp.html Part of #204
1 parent 989af6c commit 19bb1a0

File tree

11 files changed

+256
-6
lines changed

11 files changed

+256
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99
### Added
1010
- Decimal type support (#203).
1111
- UUID type support (#202).
12+
- Datetime type support and tarantool.Datetime type (#204).
1213

1314
### Changed
1415
- Bump msgpack requirement to 1.0.4 (PR #223).

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
msgpack>=1.0.4
2+
pandas

tarantool/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
ENCODING_DEFAULT,
3333
)
3434

35+
from tarantool.msgpack_ext.types import (
36+
Datetime,
37+
)
38+
3539
__version__ = "0.9.0"
3640

3741

@@ -91,7 +95,7 @@ def connectmesh(addrs=({'host': 'localhost', 'port': 3301},), user=None,
9195

9296
__all__ = ['connect', 'Connection', 'connectmesh', 'MeshConnection', 'Schema',
9397
'Error', 'DatabaseError', 'NetworkError', 'NetworkWarning',
94-
'SchemaError', 'dbapi']
98+
'SchemaError', 'dbapi', 'Datetime']
9599

96100
# ConnectionPool is supported only for Python 3.7 or newer.
97101
if sys.version_info.major >= 3 and sys.version_info.minor >= 7:

tarantool/error.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,16 @@ class MsgpackWarning(UserWarning):
119119
Warning with encoding or decoding of MP_EXT types
120120
'''
121121

122+
class ExtTypeError(ValueError):
123+
'''
124+
Error related to tarantool.Datetime type
125+
'''
126+
127+
class ExtTypeWarning(UserWarning):
128+
'''
129+
Warning related to tarantool.Datetime type
130+
'''
131+
122132
__all__ = ("Warning", "Error", "InterfaceError", "DatabaseError", "DataError",
123133
"OperationalError", "IntegrityError", "InternalError",
124134
"ProgrammingError", "NotSupportedError", "MsgpackError",

tarantool/msgpack_ext/datetime.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
from tarantool.msgpack_ext.types import Datetime
2+
3+
EXT_ID = 4
4+
5+
def encode(obj):
6+
return Datetime.msgpack_encode(obj)
7+
8+
def decode(data):
9+
return Datetime(data)

tarantool/msgpack_ext/packer.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
11
from decimal import Decimal
22
from uuid import UUID
33
from msgpack import ExtType
4+
import pandas
5+
6+
import tarantool.msgpack_ext.types as types
47

58
import tarantool.msgpack_ext.decimal as ext_decimal
69
import tarantool.msgpack_ext.uuid as ext_uuid
10+
import tarantool.msgpack_ext.datetime as ext_datetime
711

812
encoders = [
9-
{'type': Decimal, 'ext': ext_decimal},
10-
{'type': UUID, 'ext': ext_uuid },
13+
{'type': Decimal, 'ext': ext_decimal },
14+
{'type': UUID, 'ext': ext_uuid },
15+
{'type': types.Datetime, 'ext': ext_datetime},
16+
{'type': pandas.Timestamp, 'ext': ext_datetime},
1117
]
1218

1319
def default(obj):
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
from tarantool.msgpack_ext.types.datetime import Datetime
2+
3+
__all__ = ['Datetime']
Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
import pandas
2+
3+
# https://www.tarantool.io/ru/doc/latest/dev_guide/internals/msgpack_extensions/#the-datetime-type
4+
#
5+
# The datetime MessagePack representation looks like this:
6+
# +---------+----------------+==========+-----------------+
7+
# | MP_EXT | MP_DATETIME | seconds | nsec; tzoffset; |
8+
# | = d7/d8 | = 4 | | tzindex; |
9+
# +---------+----------------+==========+-----------------+
10+
# MessagePack data contains:
11+
#
12+
# * Seconds (8 bytes) as an unencoded 64-bit signed integer stored in the
13+
# little-endian order.
14+
# * The optional fields (8 bytes), if any of them have a non-zero value.
15+
# The fields include nsec (4 bytes), tzoffset (2 bytes), and
16+
# tzindex (2 bytes) packed in the little-endian order.
17+
#
18+
# seconds is seconds since Epoch, where the epoch is the point where the time
19+
# starts, and is platform dependent. For Unix, the epoch is January 1,
20+
# 1970, 00:00:00 (UTC). Tarantool uses a double type, see a structure
21+
# definition in src/lib/core/datetime.h and reasons in
22+
# https://github.com/tarantool/tarantool/wiki/Datetime-internals#intervals-in-c
23+
#
24+
# nsec is nanoseconds, fractional part of seconds. Tarantool uses int32_t, see
25+
# a definition in src/lib/core/datetime.h.
26+
#
27+
# tzoffset is timezone offset in minutes from UTC. Tarantool uses a int16_t type,
28+
# see a structure definition in src/lib/core/datetime.h.
29+
#
30+
# tzindex is Olson timezone id. Tarantool uses a int16_t type, see a structure
31+
# definition in src/lib/core/datetime.h. If both tzoffset and tzindex are
32+
# specified, tzindex has the preference and the tzoffset value is ignored.
33+
34+
SECONDS_SIZE_BYTES = 8
35+
NSEC_SIZE_BYTES = 4
36+
TZOFFSET_SIZE_BYTES = 2
37+
TZINDEX_SIZE_BYTES = 2
38+
39+
BYTEORDER = 'little'
40+
41+
NSEC_IN_SEC = 1000000000
42+
43+
44+
def get_bytes_as_int(data, cursor, size):
45+
part = data[cursor:cursor + size]
46+
return int.from_bytes(part, BYTEORDER, signed=True), cursor + size
47+
48+
def get_int_as_bytes(data, size):
49+
return data.to_bytes(size, byteorder=BYTEORDER, signed=True)
50+
51+
def msgpack_decode(data):
52+
cursor = 0
53+
seconds, cursor = get_bytes_as_int(data, cursor, SECONDS_SIZE_BYTES)
54+
55+
if len(data) > SECONDS_SIZE_BYTES:
56+
nsec, cursor = get_bytes_as_int(data, cursor, NSEC_SIZE_BYTES)
57+
tzoffset, cursor = get_bytes_as_int(data, cursor, TZOFFSET_SIZE_BYTES)
58+
tzindex, cursor = get_bytes_as_int(data, cursor, TZINDEX_SIZE_BYTES)
59+
else:
60+
nsec = 0
61+
tzoffset = 0
62+
tzindex = 0
63+
64+
if (tzoffset != 0) or (tzindex != 0):
65+
raise NotImplementedError
66+
67+
total_nsec = seconds * NSEC_IN_SEC + nsec
68+
69+
dt = pandas.to_datetime(total_nsec, unit='ns')
70+
return dt, tzoffset, tzindex
71+
72+
class Datetime(pandas.Timestamp):
73+
def __new__(cls, *args, **kwargs):
74+
if len(args) > 0 and isinstance(args[0], bytes):
75+
dt, tzoffset, tzindex = msgpack_decode(args[0])
76+
else:
77+
dt = super().__new__(cls, *args, **kwargs)
78+
79+
dt.__class__ = cls
80+
return dt
81+
82+
def msgpack_encode(self):
83+
seconds = self.value // NSEC_IN_SEC
84+
nsec = self.value % NSEC_IN_SEC
85+
tzoffset = 0
86+
tzindex = 0
87+
88+
buf = get_int_as_bytes(seconds, SECONDS_SIZE_BYTES)
89+
90+
if (nsec != 0) or (tzoffset != 0) or (tzindex != 0):
91+
buf = buf + get_int_as_bytes(nsec, NSEC_SIZE_BYTES)
92+
buf = buf + get_int_as_bytes(tzoffset, TZOFFSET_SIZE_BYTES)
93+
buf = buf + get_int_as_bytes(tzindex, TZINDEX_SIZE_BYTES)
94+
95+
return buf

tarantool/msgpack_ext/unpacker.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import tarantool.msgpack_ext.decimal as ext_decimal
22
import tarantool.msgpack_ext.uuid as ext_uuid
3+
import tarantool.msgpack_ext.datetime as ext_datetime
34

45
decoders = {
5-
ext_decimal.EXT_ID: ext_decimal.decode,
6-
ext_uuid.EXT_ID : ext_uuid.decode ,
6+
ext_decimal.EXT_ID : ext_decimal.decode ,
7+
ext_uuid.EXT_ID : ext_uuid.decode ,
8+
ext_datetime.EXT_ID: ext_datetime.decode,
79
}
810

911
def ext_hook(code, data):

test/suites/lib/skip.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,14 @@ def skip_or_run_UUID_test(func):
154154

155155
return skip_or_run_test_tarantool(func, '2.4.1',
156156
'does not support UUID type')
157+
158+
def skip_or_run_datetime_test(func):
159+
"""Decorator to skip or run datetime-related tests depending on
160+
the tarantool version.
161+
162+
Tarantool supports datetime type only since 2.10.0 version.
163+
See https://github.com/tarantool/tarantool/issues/5941
164+
"""
165+
166+
return skip_or_run_test_pcall_require(func, 'datetime',
167+
'does not support datetime type')

0 commit comments

Comments
 (0)