code-health: explicit Connection named args

Using ``**kwargs`` with ``kwargs.get`` seems like an old-style way to
force argument to be a named one. It is seems like a bad practice and
makes it harder to make a readable documentation.

Part of #67

Author: DifferentialOrange

Diff for: tarantool/connection.py

@@ -129,11 +129,11 @@ def connect(self):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def call(self, func_name, *args, **kwargs):
+    def call(self, func_name, *args):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def eval(self, expr, *args, **kwargs):
+    def eval(self, expr, *args):
         raise NotImplementedError
 
     @abc.abstractmethod
@@ -145,27 +145,28 @@ def insert(self, space_name, values):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def delete(self, space_name, key, **kwargs):
+    def delete(self, space_name, key, *, index=None):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def upsert(self, space_name, tuple_value, op_list, **kwargs):
+    def upsert(self, space_name, tuple_value, op_list, *, index=None):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def update(self, space_name, key, op_list, **kwargs):
+    def update(self, space_name, key, op_list, *, index=None):
         raise NotImplementedError
 
     @abc.abstractmethod
     def ping(self, notime):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def select(self, space_name, key, **kwargs):
+    def select(self, space_name, key, *, offset=None, limit=None,
+               index=None, iterator=None):
         raise NotImplementedError
 
     @abc.abstractmethod
-    def execute(self, query, params, **kwargs):
+    def execute(self, query, params):
         raise NotImplementedError
 
 
@@ -733,7 +734,7 @@ def insert(self, space_name, values):
         request = RequestInsert(self, space_name, values)
         return self._send_request(request)
 
-    def delete(self, space_name, key, **kwargs):
+    def delete(self, space_name, key, *, index=0):
         '''
         Execute DELETE request.
         Delete a single record identified by `key`. If you're using a secondary
@@ -746,17 +747,16 @@ def delete(self, space_name, key, **kwargs):
 
         :rtype: `Response` instance
         '''
-        index_name = kwargs.get("index", 0)
 
         key = check_key(key)
         if isinstance(space_name, str):
             space_name = self.schema.get_space(space_name).sid
-        if isinstance(index_name, str):
-            index_name = self.schema.get_index(space_name, index_name).iid
-        request = RequestDelete(self, space_name, index_name, key)
+        if isinstance(index, str):
+            index = self.schema.get_index(space_name, index).iid
+        request = RequestDelete(self, space_name, index, key)
         return self._send_request(request)
 
-    def upsert(self, space_name, tuple_value, op_list, **kwargs):
+    def upsert(self, space_name, tuple_value, op_list, *, index=0):
         '''
         Execute UPSERT request.
 
@@ -819,18 +819,17 @@ def upsert(self, space_name, tuple_value, op_list, **kwargs):
             # Delete two fields, starting with the second field
             [('#', 2, 2)]
         '''
-        index_name = kwargs.get("index", 0)
 
         if isinstance(space_name, str):
             space_name = self.schema.get_space(space_name).sid
-        if isinstance(index_name, str):
-            index_name = self.schema.get_index(space_name, index_name).iid
+        if isinstance(index, str):
+            index = self.schema.get_index(space_name, index).iid
         op_list = self._ops_process(space_name, op_list)
-        request = RequestUpsert(self, space_name, index_name, tuple_value,
+        request = RequestUpsert(self, space_name, index, tuple_value,
                                 op_list)
         return self._send_request(request)
 
-    def update(self, space_name, key, op_list, **kwargs):
+    def update(self, space_name, key, op_list, *, index=0):
         '''
         Execute an UPDATE request.
 
@@ -894,15 +893,14 @@ def update(self, space_name, key, op_list, **kwargs):
             # Delete two fields, starting with the second field
             [('#', 2, 2)]
         '''
-        index_name = kwargs.get("index", 0)
 
         key = check_key(key)
         if isinstance(space_name, str):
             space_name = self.schema.get_space(space_name).sid
-        if isinstance(index_name, str):
-            index_name = self.schema.get_index(space_name, index_name).iid
+        if isinstance(index, str):
+            index = self.schema.get_index(space_name, index).iid
         op_list = self._ops_process(space_name, op_list)
-        request = RequestUpdate(self, space_name, index_name, key, op_list)
+        request = RequestUpdate(self, space_name, index, key, op_list)
         return self._send_request(request)
 
     def ping(self, notime=False):
@@ -923,7 +921,7 @@ def ping(self, notime=False):
             return "Success"
         return t1 - t0
 
-    def select(self, space_name, key=None, **kwargs):
+    def select(self, space_name, key=None, *, offset=0, limit=0xffffffff, index=0, iterator=None):
         '''
         Execute a SELECT request.
         Select and retrieve data from the database.
@@ -964,28 +962,22 @@ def select(self, space_name, key=None, **kwargs):
         >>> select(0, [])
         '''
 
-        # Initialize arguments and its defaults from **kwargs
-        offset = kwargs.get("offset", 0)
-        limit = kwargs.get("limit", 0xffffffff)
-        index_name = kwargs.get("index", 0)
-        iterator_type = kwargs.get("iterator")
-
-        if iterator_type is None:
-            iterator_type = ITERATOR_EQ
+        if iterator is None:
+            iterator = ITERATOR_EQ
             if key is None or (isinstance(key, (list, tuple)) and
                                len(key) == 0):
-                iterator_type = ITERATOR_ALL
+                iterator = ITERATOR_ALL
 
         # Perform smart type checking (scalar / list of scalars / list of
         # tuples)
         key = check_key(key, select=True)
 
         if isinstance(space_name, str):
             space_name = self.schema.get_space(space_name).sid
-        if isinstance(index_name, str):
-            index_name = self.schema.get_index(space_name, index_name).iid
-        request = RequestSelect(self, space_name, index_name, key, offset,
-                                limit, iterator_type)
+        if isinstance(index, str):
+            index = self.schema.get_index(space_name, index).iid
+        request = RequestSelect(self, space_name, index, key, offset,
+                                limit, iterator)
         response = self._send_request(request)
         return response
 

Diff for: tarantool/connection_pool.py

@@ -446,46 +446,48 @@ def insert(self, space_name, values, *, mode=Mode.RW):
 
         return self._send(mode, 'insert', space_name, values)
 
-    def delete(self, space_name, key, *, mode=Mode.RW, **kwargs):
+    def delete(self, space_name, key, *, index=0, mode=Mode.RW):
         '''
         :param tarantool.Mode mode: Request mode (default is RW).
         '''
 
-        return self._send(mode, 'delete', space_name, key, **kwargs)
+        return self._send(mode, 'delete', space_name, key, index=index)
 
-    def upsert(self, space_name, tuple_value, op_list, *, mode=Mode.RW, **kwargs):
+    def upsert(self, space_name, tuple_value, op_list, *, index=0, mode=Mode.RW):
         '''
         :param tarantool.Mode mode: Request mode (default is RW).
         '''
 
         return self._send(mode, 'upsert', space_name, tuple_value,
-            op_list, **kwargs)
+            op_list, index=index)
 
-    def update(self, space_name, key, op_list, *, mode=Mode.RW, **kwargs):
+    def update(self, space_name, key, op_list, *, index=0, mode=Mode.RW):
         '''
         :param tarantool.Mode mode: Request mode (default is RW).
         '''
 
         return self._send(mode, 'update', space_name, key, 
-            op_list, **kwargs)
+            op_list, index=index)
 
-    def ping(self, *, mode=None, **kwargs):
+    def ping(self, notime=False, *, mode=None):
         '''
         :param tarantool.Mode mode: Request mode.
         '''
 
         if mode is None:
             raise ValueError("Please, specify 'mode' keyword argument")
 
-        return self._send(mode, 'ping', **kwargs)
+        return self._send(mode, 'ping', notime)
 
-    def select(self, space_name, key, *, mode=Mode.ANY, **kwargs):
+    def select(self, space_name, key, *, offset=0, limit=0xffffffff,
+               index=0, iterator=None, mode=Mode.ANY):
         '''
         :param tarantool.Mode mode: Request mode (default is
             ANY).
         '''
 
-        return self._send(mode, 'select', space_name, key, **kwargs)
+        return self._send(mode, 'select', space_name, key, offset=offset, limit=limit,
+                          index=index, iterator=iterator)
 
     def execute(self, query, params=None, *, mode=None):
         '''