Skip to content

IPROTO_ID follow up #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DifferentialOrange opened this issue Nov 30, 2022 · 1 comment · Fixed by #296
Closed

IPROTO_ID follow up #267

DifferentialOrange opened this issue Nov 30, 2022 · 1 comment · Fixed by #296
Assignees
@DifferentialOrange
Labels
feature A new functionality

Comments

@DifferentialOrange
Copy link
Member

DifferentialOrange commented Nov 30, 2022 •
edited
Loading

While implementing IPROTO_ID in go-tarantool (see tarantool/go-tarantool#226), we had discovered that some things could be done better, like

  • storing server and client version and features separately,
  • requiring protocol version/features on connect to fast fail if server doesn't support then.

We need to catch on the Go implementation.
@DifferentialOrange DifferentialOrange added feature A new functionality teamE labels Nov 30, 2022
@DifferentialOrange
Copy link
Member Author

It seems that _check_features is not triggerred on reconnect.

DifferentialOrange added a commit that referenced this issue Dec 23, 2022
@DifferentialOrange
iproto: add new protocol feature codes
05168e4 
IPROTO_FEATURE_PAGINATION (code 4) and protocol version 4 was added in
Tarantool master [1].

1. tarantool/tarantool@948e5cd

Part of #267
@DifferentialOrange DifferentialOrange self-assigned this Jun 26, 2023
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
iproto: provide new features codes
80c12dc 
Pagination was added in Tarantool 2.11.0-rc1 [1]. Space and index names
support will be added to Tarantool 3.0 [2]. Watch once feature will be
added to Tarantool 3.0 [3].

1. tarantool/tarantool@948e5cd
2. tarantool/tarantool@b9550f1
3. tarantool/tarantool@6dc1433

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
api: allow to require protocol version and features
139049c 
Allow to set required_protocol_version and required_protocol_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
@DifferentialOrange DifferentialOrange mentioned this issue Jun 27, 2023
Merged
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
api: allow to require protocol version and features
c34cb62 
Allow to set required_protocol_version and required_protocol_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
conn: store client and server protocol info
8d2b11b 
Store client and server protocol version and features in connection
object, similar to go-tarantool [1]. Before the patch, we stored only
products: minimal protocol version of server and client and the list
of features supported both by client and server.

1. tarantool/go-tarantool#226

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
api: allow to require protocol version and features
11735d9 
Allow to set required_protocol_version and required_protocol_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
conn: store client and server protocol info
8a093c6 
Store client and server protocol version and features in connection
object, similar to go-tarantool [1]. Before the patch, we stored only
products: minimal protocol version of server and client and the list
of features supported both by client and server.

1. tarantool/go-tarantool#226

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
api: allow to require protocol version and features
2bedbd9 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 27, 2023
@DifferentialOrange
api: allow to require protocol version and features
c5b7535 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
api: allow to require protocol version and features
a354d78 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
conn: store client and server protocol info
b500a3e 
Store client and server protocol version and features in connection
object, similar to go-tarantool [1]. Before the patch, we stored only
products: minimal protocol version of server and client and the list
of features supported both by client and server.

1. tarantool/go-tarantool#226

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
api: allow to require protocol version and features
c10c898 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
api: allow to require protocol version and features
17524ee 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
iproto: provide new features codes
7848ac7 
Pagination was added in Tarantool 2.11.0-rc1 [1]. Space and index names
support will be added to Tarantool 3.0 [2]. Watch once feature will be
added to Tarantool 3.0 [3].

1. tarantool/tarantool@948e5cd
2. tarantool/tarantool@b9550f1
3. tarantool/tarantool@6dc1433

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
conn: store client and server protocol info
b0c18a3 
Store client and server protocol version and features in connection
object, similar to go-tarantool [1]. Before the patch, we stored only
products: minimal protocol version of server and client and the list
of features supported both by client and server.

1. tarantool/go-tarantool#226

Part of #267
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
@DifferentialOrange
api: allow to require protocol version and features
e954c4c 
Allow to set required_protocol_version and required_features on
connection initialization to ensure that a Tarantool server provides
expected features. The approach is similar to go-tarantool [1]. We do
not check client protocol version and features, similar to the core
Tarantool [1, 2].

1. tarantool/go-tarantool#226
2. tarantool/tarantool#7953

Closes #267
DifferentialOrange added a commit that referenced this issue Jun 30, 2023
@DifferentialOrange
release 1.1.0
40199a8 
Overview

  This release inroduces API to request server protocol version and
  feature, as well as introduce decimal bugfix.

Breaking changes

  - Drop `msgpack-python` support. (Package not supported since 2019.)
    Use `msgpack` instead.

Added
  - Allow to require specific server protocol version
    and features (#267).

Fixed
  - Parsing of E-notation Tarantool decimals with positive
    exponent (PR #298).
@DifferentialOrange DifferentialOrange mentioned this issue Jun 30, 2023
Merged
DifferentialOrange added a commit that referenced this issue Jun 30, 2023
@DifferentialOrange
release 1.1.0
63b7b4f 
Overview

  This release introduces API to request server protocol version and
  feature, as well as introduce decimal bugfix.

Breaking changes

  - Drop `msgpack-python` support. (Package not supported since 2019.)
    Use `msgpack` instead.

Added
  - Allow to require specific server protocol version
    and features (#267).

Fixed
  - Parsing of E-notation Tarantool decimals with positive
    exponent (PR #298).
DifferentialOrange added a commit that referenced this issue Jun 30, 2023
@DifferentialOrange
release 1.1.0
0307044 
Overview

  This release introduces API to request server protocol version and
  feature, as well as introduce decimal bugfix.

Breaking changes

  - Drop `msgpack-python` support. (Package not supported since 2019.)
    Use `msgpack` instead.

Added
  - Allow to require specific server protocol version
    and features (#267).

Fixed
  - Parsing of E-notation Tarantool decimals with positive
    exponent (PR #298).
DifferentialOrange added a commit that referenced this issue Jun 30, 2023
@DifferentialOrange
release 1.1.0
2056c5c 
Overview

  This release introduces API to request server protocol version and
  feature, as well as introduce decimal bugfix.

Breaking changes

  - Drop `msgpack-python` support. (Package not supported since 2019.)
    Use `msgpack` instead.

Added
  - Allow to require specific server protocol version
    and features (#267).

Fixed
  - Parsing of E-notation Tarantool decimals with positive
    exponent (PR #298).
DifferentialOrange added a commit that referenced this issue Jun 30, 2023
@DifferentialOrange
release 1.1.0
1427094 
Overview

  This release introduces API to request server protocol version and
  feature, as well as introduce decimal bugfix.

Breaking changes

  - Drop `msgpack-python` support. (Package not supported since 2019.)
    Use `msgpack` instead.

Added
  - Allow to require specific server protocol version
    and features (#267).

Fixed
  - Parsing of E-notation Tarantool decimals with positive
    exponent (PR #298).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DifferentialOrange DifferentialOrange

Labels
feature A new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make feature discovery similar to go-tarantool tarantool/tarantool-python
2 participants
@DifferentialOrange @TarantoolBot