-
Notifications
You must be signed in to change notification settings - Fork 46
backward compatibility is broken: module is not compatible with cartridge remote control #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
olegrok
added a commit
to olegrok/tarantool-python
that referenced
this issue
Feb 27, 2023
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes tarantool#283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
olegrok
added a commit
to olegrok/tarantool-python
that referenced
this issue
Feb 27, 2023
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes tarantool#283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
olegrok
added a commit
to olegrok/tarantool-python
that referenced
this issue
Feb 27, 2023
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes tarantool#283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
DifferentialOrange
pushed a commit
that referenced
this issue
Feb 27, 2023
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes #283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After update to 0.12.0 some my tests started to fail with following backtrace:
tarantoolctl is able to connect to my instance. However tarantool-python is not.
Seems it happens because module now is not compatible with cartridge.remote-control (and probably some ancient Tarantool versions). There is workaround in cartridge code to make it compatible with netbox - tarantool/cartridge@1649b40 but seems these connector doesn't consider it.
The text was updated successfully, but these errors were encountered: