Skip to content

Remove luatest submodule #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
locker opened this issue Apr 8, 2025 · 0 comments · May be fixed by #454
Open

Remove luatest submodule #453

locker opened this issue Apr 8, 2025 · 0 comments · May be fixed by #454
Assignees
@locker

Comments

@locker
Copy link
Member

locker commented Apr 8, 2025

Having luatest as a submodule is inconvenient because:

  1. To update luatest in some project using it via test-run, we have to update it in test-run first.
  2. From point 1 it follows that all projects using test-run are bound to use the same version of luatest.

Let's drop the luatest submodule from test-run and require projects using test-run install luatest as a prerequisite, either as a submodule or from luarocks.
@locker locker self-assigned this Apr 11, 2025
locker added a commit that referenced this issue Apr 11, 2025
@locker
Remove luatest and checks submodules
09ab978 
The `test-run` project is rarely updated these days while `luatest` is
rapidly developing. Let's remove the `luatest` submodule from `test-run`
to ease luatest bumps in projects using `test-run`. Now, `luatest` is
supposed to be added as a submodule to all projects using `test-run`.

By default, `test-run` looks for `luatest` in `../third_party/luatest`,
but this can be overridden with the new `--luatestdir option`.

Note that we also remove the `checks` submodule, which was added as
a dependency of `luatest`. It was built in Tarantool in 2.11.0 so
there's no need in it anymore.

Closes #453
@locker locker linked a pull request Apr 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@locker locker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove luatest and checks submodules tarantool/test-run
1 participant
@locker