Skip to content

Vshard shows alerts for replica, which are not in the vshard's config #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serpentian opened this issue Oct 14, 2024 · 0 comments · May be fixed by #544
Open

Vshard shows alerts for replica, which are not in the vshard's config #493

Serpentian opened this issue Oct 14, 2024 · 0 comments · May be fixed by #544
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Serpentian
Copy link
Collaborator

Serpentian commented Oct 14, 2024

The problem here is that, if we connect any kind of replica to our shard, vshard will suppose, that it's part of the current shard, master will throw errors for this replicas:

-- Use example, add replica (let's suppose, this is non anon CDC)
tarantool> box.cfg{replication = {'storage:[email protected]:3301', 'storage:[email protected]:3302'}}

----

-- Now on `replica_1_a` we'll see:
unix/:./data/storage_1_a.control> vshard.storage.info()
<...>
  alerts:
  - ['UNREACHABLE_REPLICA', 'Replica 5891c9d7-a7f4-4fca-b9bc-07246c040141 isn''t active']
  - ['LOW_REDUNDANCY', 'Only one replica is active']

Master should not alert about replicas, which are not in vshard's config.

@Serpentian Serpentian added bug Something isn't working good first issue Good for newcomers labels Oct 14, 2024
mrForza added a commit to mrForza/vshard that referenced this issue Apr 18, 2025
In test `test_named_hot_reload` there is no reconfiguration to
uuid_as_key identification_mode in the end of the test. This
test negatively influences other tests which expect uuid_as_key
identification_mode.

Needed for tarantool#493

NO_DOC=test
mrForza added a commit to mrForza/vshard that referenced this issue Apr 18, 2025
The function `assert_server_no_alerts` is moved from
`persistent_names_test` into `test/luatest_helpers/asserts.lua`.
This change has been made in order to use this function in subsequent
commit in `test_alerts_for_non_vshard_config_template`. Also some usages
of this function are changed in `persistent_names_test` with `asserts`
module.

Needed for tarantool#493

NO_DOC=test
mrForza added a commit to mrForza/vshard that referenced this issue Apr 18, 2025
This test expected alert for non-vshard replica to be shown, which is
incorrect behavior and will be fixed in the subsequent commit.

Needed for tarantool#493

NO_DOC=test
mrForza added a commit to mrForza/vshard that referenced this issue Apr 18, 2025
Before this patch vshard throwed alerts for replicas, which are not in
its config. E.g. disconnected CDC replica caused `UNREACHABLE_REPLICA`
alert. This patch fixes it by skipping unknown replicas.

Closes tarantool#493

NO_DOC=bugfix
mrForza added a commit to mrForza/vshard that referenced this issue Apr 18, 2025
This test checks scenario when replica disconnects from replicaset
in named vshard config. In this situation two alerts should be thrown:
`UNREACHABLE_REPLICA` and `UNREACHABLE_REPLICASET`. It is necessary to
add this test in order to reduce untested places in the codebase. Also
a function `info_assert_alert` is removed from `router_2_2_test` since
there is a more appropriate function in `asserts` module.

Follow-up tarantool#493

NO_DOC=test
@mrForza mrForza linked a pull request Apr 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants