-
Notifications
You must be signed in to change notification settings - Fork 32
Vshard shows alerts for replica, which are not in the vshard's config #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
mrForza
added a commit
to mrForza/vshard
that referenced
this issue
Apr 18, 2025
In test `test_named_hot_reload` there is no reconfiguration to uuid_as_key identification_mode in the end of the test. This test negatively influences other tests which expect uuid_as_key identification_mode. Needed for tarantool#493 NO_DOC=test
mrForza
added a commit
to mrForza/vshard
that referenced
this issue
Apr 18, 2025
The function `assert_server_no_alerts` is moved from `persistent_names_test` into `test/luatest_helpers/asserts.lua`. This change has been made in order to use this function in subsequent commit in `test_alerts_for_non_vshard_config_template`. Also some usages of this function are changed in `persistent_names_test` with `asserts` module. Needed for tarantool#493 NO_DOC=test
mrForza
added a commit
to mrForza/vshard
that referenced
this issue
Apr 18, 2025
This test expected alert for non-vshard replica to be shown, which is incorrect behavior and will be fixed in the subsequent commit. Needed for tarantool#493 NO_DOC=test
mrForza
added a commit
to mrForza/vshard
that referenced
this issue
Apr 18, 2025
Before this patch vshard throwed alerts for replicas, which are not in its config. E.g. disconnected CDC replica caused `UNREACHABLE_REPLICA` alert. This patch fixes it by skipping unknown replicas. Closes tarantool#493 NO_DOC=bugfix
mrForza
added a commit
to mrForza/vshard
that referenced
this issue
Apr 18, 2025
This test checks scenario when replica disconnects from replicaset in named vshard config. In this situation two alerts should be thrown: `UNREACHABLE_REPLICA` and `UNREACHABLE_REPLICASET`. It is necessary to add this test in order to reduce untested places in the codebase. Also a function `info_assert_alert` is removed from `router_2_2_test` since there is a more appropriate function in `asserts` module. Follow-up tarantool#493 NO_DOC=test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem here is that, if we connect any kind of replica to our shard, vshard will suppose, that it's part of the current shard, master will throw errors for this replicas:
Master should not alert about replicas, which are not in vshard's config.
The text was updated successfully, but these errors were encountered: