Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cull weak lines from VALD linelists #415

Open
jvshields opened this issue Oct 9, 2024 · 1 comment
Open

Cull weak lines from VALD linelists #415

jvshields opened this issue Oct 9, 2024 · 1 comment

Comments

@jvshields
Copy link
Contributor

Currently, VALD linelists can include thousands to tens of thousands of lines that may effectively not contribute to a stellar spectrum computed by STARDIS. I believe parsers and subsequent handling of other sources has some functionality to handle situations like this, and it would be good to include in our VALD handling.

@manas-dhyani
Copy link

Hi @jvshields,

I'm working on implementing the culling of weak lines from VALD linelists for issue #415. Would you recommend specific thresholds for log_gf or e_low, or should they be based on existing filtering criteria used in other linelists?

Currently, I’m considering using log_gf > -5 and e_low > 0.1 eV, but I’d like to confirm whether these values are appropriate.Looking forward to your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants