Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence restructure #2518

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Feb 12, 2024

📝 Description

Type: 🎢 infrastructure

This PR will take convergence handling out of the simulation and into a new class.

🚦 Testing

How did you test these changes?

  • Testing pipeline

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (6fffa69) to head (0002f81).
Report is 1 commits behind head on master.

Current head 0002f81 differs from pull request most recent head 8e45a12

Please upload reports for the commit 8e45a12 to get more accurate results.

Files Patch % Lines
tardis/simulation/convergence.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2518      +/-   ##
==========================================
+ Coverage   67.76%   68.72%   +0.96%     
==========================================
  Files         172      166       -6     
  Lines       14415    14007     -408     
==========================================
- Hits         9769     9627     -142     
+ Misses       4646     4380     -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

tardis-bot commented Mar 6, 2024

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@wkerzendorf
Copy link
Member

Make different classes for different convergence strategies.
Track all values for convergence.

@andrewfullard andrewfullard marked this pull request as draft March 11, 2024 14:09
@andrewfullard andrewfullard marked this pull request as ready for review May 8, 2024 18:08
@andrewfullard
Copy link
Contributor Author

Let's get this merged to help Deeksha work on convergence

Copy link
Member

@Knights-Templars Knights-Templars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for the new functions.

wkerzendorf
wkerzendorf previously approved these changes Jun 7, 2024
@wkerzendorf wkerzendorf merged commit 41bcf24 into tardis-sn:master Jun 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants