-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken URL in generating_widgets.ipynb #2533
Conversation
@MarkMageeAstro @jamesgillanders please review. Also please apply |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
*beep* *bop* Hi, human. The Click here to see your results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Sarthak.
I don't know why doc build failed, even though I only changed the URL in a markdown cell. |
Maybe someone else can comment on the fails. Seems like a simple fix so I imagine it's not just this PR |
It's the usual annoying random docs fail due to hdf files. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2533 +/- ##
==========================================
- Coverage 68.74% 68.73% -0.01%
==========================================
Files 165 165
Lines 13999 14001 +2
==========================================
+ Hits 9623 9624 +1
- Misses 4376 4377 +1 ☔ View full report in Codecov by Sentry. |
@sarthak-dv please add yourself to the mailmap! You can use the no-reply github email address if you like. |
@andrewfullard Updated the mailmap |
📝 Description
Fixed broken URL as pointed by the linked issue.
Type: 🪲
bugfix
Resolves #2532
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label