Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URL in generating_widgets.ipynb #2533

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

sarthak-dv
Copy link
Contributor

@sarthak-dv sarthak-dv commented Mar 8, 2024

📝 Description

Fixed broken URL as pointed by the linked issue.

Type: 🪲 bugfix

Resolves #2532

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method: Tested the URL
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@sarthak-dv
Copy link
Contributor Author

sarthak-dv commented Mar 8, 2024

@MarkMageeAstro @jamesgillanders please review. Also please apply build-docs label

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Mar 8, 2024

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@AyushiDaksh AyushiDaksh self-requested a review March 8, 2024 04:35
Copy link
Contributor

@AyushiDaksh AyushiDaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Sarthak.

@sarthak-dv
Copy link
Contributor Author

I don't know why doc build failed, even though I only changed the URL in a markdown cell.

MarkMageeAstro
MarkMageeAstro previously approved these changes Mar 8, 2024
@MarkMageeAstro
Copy link
Contributor

Maybe someone else can comment on the fails. Seems like a simple fix so I imagine it's not just this PR

@andrewfullard
Copy link
Contributor

Maybe someone else can comment on the fails. Seems like a simple fix so I imagine it's not just this PR

It's the usual annoying random docs fail due to hdf files.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (64df98b) to head (d75f140).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2533      +/-   ##
==========================================
- Coverage   68.74%   68.73%   -0.01%     
==========================================
  Files         165      165              
  Lines       13999    14001       +2     
==========================================
+ Hits         9623     9624       +1     
- Misses       4376     4377       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard
Copy link
Contributor

@sarthak-dv please add yourself to the mailmap! You can use the no-reply github email address if you like.

@sarthak-dv
Copy link
Contributor Author

@andrewfullard Updated the mailmap

@andrewfullard andrewfullard enabled auto-merge (squash) March 11, 2024 14:09
@andrewfullard andrewfullard merged commit f515d16 into tardis-sn:master Mar 11, 2024
12 checks passed
@sarthak-dv sarthak-dv deleted the fix-url branch March 11, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken URL in generating_widgets.ipynb
7 participants