[GSOC] Velocity Packet Tracker Visualization First Objective #2538
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
|
@andrewfullard @wkerzendorf, Can anyone please review this? Thanks. |
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
| @@ -0,0 +1,3493 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think it's meaningful to show legend in this plot since we have no other color
Reply via ReviewNB
There was a problem hiding this comment.
Thanks for submitting first objective @Sumit112192
I like the documentation of your thought process in your notebook. It will be nice to see the produced plots in plotly too (since our visualisation tools use both matplotlib and plotly).
Also, you didn't have to push markdown and images since we can see the rendered notebook through ReviewNB - feel free to take them out.
Looking forward to your proposal!
|
@jaladh-singhal Thanks for the review. I will make the changes that were suggested. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2538 +/- ##
=======================================
Coverage 68.18% 68.18%
=======================================
Files 168 168
Lines 14219 14219
=======================================
Hits 9695 9695
Misses 4524 4524 ☔ View full report in Codecov by Sentry. |
|
View / edit / reply to this conversation on ReviewNB jamesgillanders commented on 2024-03-29T15:31:32Z Consider a different y-axis scale, since the less abundant elements are not well-visualised here |
|
View / edit / reply to this conversation on ReviewNB jamesgillanders commented on 2024-03-29T15:31:33Z Consider a different y-axis scale |
|
Hi Sumit, looks good. Please take a look at the comments I left on the notebook |
|
@jamesgillanders I will make the changes as suggested. Also, will you please take a look at the doc version of my proposal, I have refined it. |
|
@jamesgillanders How should I share the link of the doc version of my proposal? |
|
I have already reviewed the draft proposal and added comments earlier today
On 29 Mar 2024, at 15:49, Sumit Gupta ***@***.***> wrote:
@jamesgillanders<https://github.com/jamesgillanders> How should I share the link of the doc version of my proposal?
—
Reply to this email directly, view it on GitHub<#2538 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALJQVQS3NDC2KJAJYOGRX4TY2WEQ3AVCNFSM6AAAAABEPGBEZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQYDSMBYG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
📝 Description
Type: 🎢
gsocThis pull request contains my
first objectiveapproach ofVelocity Packet Tracker Visualization.It contains a jupyter
.ipynbfile and a folder containing the markdown files of the corresponding jupyter file.📌 Resources
https://app.reviewnb.com/Sumit112192/tardis/blob/first-objective/VelocityPacketTrackerFirstObjective.ipynb/
Please let me know if the above link is not working.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel