-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine: refactor rotations to process through job queue #4269
Open
mastercactapus
wants to merge
17
commits into
master
Choose a base branch
from
rotation-job-setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion and state handling
…om rotation manager
…c from DB initialization
…ng with event notifications
…e lookForWork comments
…ersions and return error for unknown versions
AlaricWhitney
requested changes
Feb 10, 2025
…n functions for clarity
AlaricWhitney
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Migrates rotation processing to the job queue. Uses the existing advancement calculation function without any changes to logic.
Notes:
entity_updates
table to track changes to rotations via DB trigger as a fallbackupdateRotation
mutation to schedule a job immediatelycalcAdvance
was updated to abort for unknown rotation state versionsWhich issue(s) this PR fixes:
Closes #4244
Additional Info:
The previous approach updated all rotations every 5 seconds; this one will update rotations immediately on change and when the individual rotation is meant to advance.