Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit to accept references #9

Closed
hansieodendaal opened this issue May 30, 2022 · 1 comment
Closed

Update commit to accept references #9

hansieodendaal opened this issue May 30, 2022 · 1 comment

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented May 30, 2022

It's unfortunate that the BP+ API forces copies :(

There are a few ways to remove this need:

Update commit in the BP+ API to accept I: Iterator<Item=&Scalar>, then you can pass in k_i.iter().map(|k| &k.0)

Or take something like

pub fn commit<S: AsRef<Scalar>>(&self, value: Scalar, blindings: &[S]) -> Result<P, ProofError> 

Either way, it requires changes to the BP+ repo, which is not something we can do in this PR.

Originally posted by @CjS77 in tari-project/tari-crypto#99 (comment)

@hansieodendaal
Copy link
Contributor Author

See #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant