From 7de4ab99ad765c03de7d56a1cd9cd129a9037de2 Mon Sep 17 00:00:00 2001 From: Martin Stefcek <35243812+Cifko@users.noreply.github.com> Date: Fri, 19 Jan 2024 09:16:32 +0100 Subject: [PATCH] fix: uncomment sync cucumber test (#905) Description --- It looks like the test is working. I had rerun it couple of times. Motivation and Context --- How Has This Been Tested? --- `cargo test --test cucumber -- -n "New validator node registers and syncs"` What process can a PR reviewer use to test or verify this change? --- `cargo test --test cucumber -- -n "New validator node registers and syncs"` Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify --- .../tests/features/block_sync.feature | 105 +++++++++--------- 1 file changed, 52 insertions(+), 53 deletions(-) diff --git a/integration_tests/tests/features/block_sync.feature b/integration_tests/tests/features/block_sync.feature index 8f860d822..615537c9d 100644 --- a/integration_tests/tests/features/block_sync.feature +++ b/integration_tests/tests/features/block_sync.feature @@ -3,57 +3,56 @@ Feature: Block Sync -# This is flaky, we should fix it -# @serial -# Scenario: New validator node registers and syncs -# # Initialize a base node, wallet, miner and VN -# Given a base node BASE -# Given a wallet WALLET connected to base node BASE -# Given a miner MINER connected to base node BASE and wallet WALLET - -# # Initialize an indexer -# Given an indexer IDX connected to base node BASE - -# # Initialize the wallet daemon -# Given a wallet daemon WALLET_D connected to indexer IDX -# When I create a key named K1 for WALLET_D - -# # Initialize a VN -# Given a seed validator node VN connected to base node BASE and wallet WALLET -# When miner MINER mines 4 new blocks -# When wallet WALLET has at least 5000 T -# When validator node VN sends a registration transaction allowing fee claims from wallet WALLET_D using key K1 -# When miner MINER mines 16 new blocks -# Then VN has scanned to height 17 -# And indexer IDX has scanned to height 17 -# Then the validator node VN is listed as registered - -# When indexer IDX connects to all other validators - -# # Submit a few transactions -# When I create an account ACC1 via the wallet daemon WALLET_D with 10000 free coins -# When I create an account UNUSED1 via the wallet daemon WALLET_D -# When I create an account UNUSED2 via the wallet daemon WALLET_D -# When I create an account UNUSED3 via the wallet daemon WALLET_D - -# When I wait for validator VN has leaf block height of at least 20 - -# # Start a new VN that needs to sync -# Given a validator node VN2 connected to base node BASE and wallet WALLET -# Given validator VN2 nodes connect to all other validators -# When indexer IDX connects to all other validators - -# When validator node VN2 sends a registration transaction allowing fee claims from wallet WALLET_D using key K1 -# When miner MINER mines 20 new blocks -# Then VN has scanned to height 37 -# Then VN2 has scanned to height 37 -# Then the validator node VN2 is listed as registered - -# When I wait for validator VN2 has leaf block height of at least 20 - -# When I create an account UNUSED4 via the wallet daemon WALLET_D -# When I create an account UNUSED5 via the wallet daemon WALLET_D - -# When I wait for validator VN has leaf block height of at least 26 -# When I wait for validator VN2 has leaf block height of at least 26 + @serial + Scenario: New validator node registers and syncs + # Initialize a base node, wallet, miner and VN + Given a base node BASE + Given a wallet WALLET connected to base node BASE + Given a miner MINER connected to base node BASE and wallet WALLET + + # Initialize an indexer + Given an indexer IDX connected to base node BASE + + # Initialize the wallet daemon + Given a wallet daemon WALLET_D connected to indexer IDX + When I create a key named K1 for WALLET_D + + # Initialize a VN + Given a seed validator node VN connected to base node BASE and wallet WALLET + When miner MINER mines 4 new blocks + When wallet WALLET has at least 5000 T + When validator node VN sends a registration transaction allowing fee claims from wallet WALLET_D using key K1 + When miner MINER mines 16 new blocks + Then VN has scanned to height 17 + And indexer IDX has scanned to height 17 + Then the validator node VN is listed as registered + + When indexer IDX connects to all other validators + + # Submit a few transactions + When I create an account ACC1 via the wallet daemon WALLET_D with 10000 free coins + When I create an account UNUSED1 via the wallet daemon WALLET_D + When I create an account UNUSED2 via the wallet daemon WALLET_D + When I create an account UNUSED3 via the wallet daemon WALLET_D + + When I wait for validator VN has leaf block height of at least 20 + + # Start a new VN that needs to sync + Given a validator node VN2 connected to base node BASE and wallet WALLET + Given validator VN2 nodes connect to all other validators + When indexer IDX connects to all other validators + + When validator node VN2 sends a registration transaction allowing fee claims from wallet WALLET_D using key K1 + When miner MINER mines 20 new blocks + Then VN has scanned to height 37 + Then VN2 has scanned to height 37 + Then the validator node VN2 is listed as registered + + When I wait for validator VN2 has leaf block height of at least 20 + + When I create an account UNUSED4 via the wallet daemon WALLET_D + When I create an account UNUSED5 via the wallet daemon WALLET_D + + When I wait for validator VN has leaf block height of at least 26 + When I wait for validator VN2 has leaf block height of at least 26