Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: remove prepare command #1314

Open
sdbondi opened this issue Feb 28, 2025 · 0 comments
Open

consensus: remove prepare command #1314

sdbondi opened this issue Feb 28, 2025 · 0 comments
Milestone

Comments

@sdbondi
Copy link
Member

sdbondi commented Feb 28, 2025

Prepare command is not necessary.

Prepare asserts that all local validators agree on input pledges. LocalPrepare asserts that all validators have seen the prepare.
However, the last assertion is intrinsic to the hotstuff consensus i.e. a 3 chain guarantees that all have seen and agree to the command and its pledges and know that all have seen the required QCs. In this case, LocalPrepare can prepare and pledge and by committing this command, we already have both assertions. This becomes obvious by looking at the code for LocalPrepare, which does very little.

Similar logic applies to AllPrepared/LocalAccept, if we are proceeding to LocalAccept then AllPrepared is implicit

@sdbondi sdbondi converted this from a draft issue Feb 28, 2025
@sdbondi sdbondi added this to the v0.8.0 milestone Feb 28, 2025
@sdbondi sdbondi moved this from Backlog to In Progress in Tari Digital Assets Network (DAN) backlog Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant