Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fees] investigate why fees differ for the same transactions #906

Closed
Cifko opened this issue Jan 19, 2024 · 3 comments
Closed

[fees] investigate why fees differ for the same transactions #906

Cifko opened this issue Jan 19, 2024 · 3 comments
Assignees

Comments

@Cifko
Copy link
Contributor

Cifko commented Jan 19, 2024

Validators agree on the same fee, but they differ for stress test transactions by a few uXTR2.
This is probably because there are differences in the size of the outputs, which may be valid but still warrants investigation.

@Cifko Cifko converted this from a draft issue Jan 19, 2024
@Cifko Cifko self-assigned this Jan 19, 2024
@Cifko
Copy link
Contributor Author

Cifko commented Jan 19, 2024

data : VaultId(BorTag(Required(Hash([163, 139, 31, 151, 15, 72, 234, 94, 118, 54, 122, 136, 190, 33, 68, 242, 171, 79, 225, 98, 81, 232, 184, 173, 201, 84, 197, 153, 127, 88, 87, 21]))))

CBOR : [216, 132, 152, 32, 24, 163, 24, 139, 24, 31, 24, 151, 15, 24, 72, 24, 234, 24, 94, 24, 118, 24, 54, 24, 122, 24, 136, 24, 190, 24, 33, 24, 68, 24, 242, 24, 171, 24, 79, 24, 225, 24, 98, 24, 81, 24, 232, 24, 184, 24, 173, 24, 201, 24, 84, 24, 197, 24, 153, 24, 127, 24, 88, 24, 87, 21]

Size: 66


data : VaultId(BorTag(Required(Hash([129, 17, 173, 127, 177, 111, 239, 53, 130, 57, 249, 68, 20, 35, 255, 7, 26, 168, 77, 164, 123, 95, 21, 74, 252, 245, 82, 176, 195, 222, 113, 14]))))

CBOR: [216, 132, 152, 32, 24, 129, 17, 24, 173, 24, 127, 24, 177, 24, 111, 24, 239, 24, 53, 24, 130, 24, 57, 24, 249, 24, 68, 20, 24, 35, 24, 255, 7, 24, 26, 24, 168, 24, 77, 24, 164, 24, 123, 24, 95, 21, 24, 74, 24, 252, 24, 245, 24, 82, 24, 176, 24, 195, 24, 222, 24, 113, 14]

Size: 63

@stringhandler
Copy link
Contributor

What's the purpose of the 24's in between every array element? The second one has 26x24s and the first has 29x24s in the array portion (i.e. after the 163 in the first and 129 in the second)

@Cifko Cifko moved this from In Progress to In Review in Tari Digital Assets Network (DAN) backlog Jan 22, 2024
@Cifko
Copy link
Contributor Author

Cifko commented Jan 22, 2024

What's the purpose of the 24's in between every array element? The second one has 26x24s and the first has 29x24s in the array portion (i.e. after the 163 in the first and 129 in the second)

Honestly I don't know why is CBOR encoding this way. You can test the CBOR encoding on http://cbor.me (any number >=24 will have extra byte).

#909 solved this

@Cifko Cifko closed this as completed Jan 22, 2024
@Cifko Cifko moved this from In Review to Done in Tari Digital Assets Network (DAN) backlog Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants