You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: qc was validated based on current epoch, not the qc's epoch (#896)
Description
---
The qc validation was based on the epoch of the candidate block. So if
the QC was from previous epoch the committee shard could be different.
E.g. when you add a new VN into the committee, the qc was expected to
have 2 signatures. But in the previous epoch there was only one VN so
the QC never passed the validation.
Motivation and Context
---
How Has This Been Tested?
---
Start dan-testing with 1 VN, add a new VN and mine it into the
committee. Without this change you would never see a new block coming
in. You still have to wait for some leader failure on the epoch change
but eventually new blocks starts coming in.
What process can a PR reviewer use to test or verify this change?
---
As above.
Breaking Changes
---
- [x] None
- [ ] Requires data directory to be deleted
- [ ] Other - Please specify
Co-authored-by: Stan Bondi <[email protected]>
0 commit comments