breaking: remove cert-manager support from helm chart

Right now we have experimental support for Cert Manager installation
in the chart. As part of this, we store Cert Manager CRDs in the "crds"
folder. If you install the chart with Helm, everything works fine,
resources are only installed if they don't exist in the cluster.
But if we use Argo, we always install CRDs even if they already exist
by overwriting them. Since we can't get around this limitation, we
decided to remove Cert Manager support from the chart.

We recommend using the clusterctl plugin for local development and
testing that retains support for installing Cert Manager. In the case
of the chart, users must manage Cert Manager installation themselves.

Author: Fedosin

Makefile

@@ -480,7 +480,6 @@ release-manifests: $(KUSTOMIZE) $(RELEASE_DIR) ## Builds the manifests to publis
 release-chart: $(HELM) $(KUSTOMIZE) $(RELEASE_DIR) $(CHART_DIR) $(CHART_PACKAGE_DIR) ## Builds the chart to publish with a release
 	cp -rf $(ROOT)/hack/charts/cluster-api-operator/. $(CHART_DIR)
 	$(KUSTOMIZE) build ./config/chart > $(CHART_DIR)/templates/operator-components.yaml
-	$(ROOT)/hack/inject-cert-manager-chart-version.sh $(CERT_MANAGER_VERSION)
 	$(HELM) package $(CHART_DIR) --app-version=$(HELM_CHART_TAG) --version=$(HELM_CHART_TAG) --destination=$(CHART_PACKAGE_DIR)
 
 .PHONY: release-staging

hack/charts/cluster-api-operator/Chart.yaml

@@ -4,8 +4,3 @@ description: Cluster API Operator
 type: application
 version: 0.0.0
 appVersion: "0.0.0"
-dependencies:
-  - name: cert-manager
-    version: "0.0.0"
-    repository: https://charts.jetstack.io
-    condition: cert-manager.enabled

hack/charts/cluster-api-operator/templates/cert-manager.namespace.yaml

@@ -1,11 +1,4 @@
 ---
-# Cert Manager options
-# Full list of supported values is available at https://artifacthub.io/packages/helm/cert-manager/cert-manager
-cert-manager:
-  enabled: false
-  fullnameOverride: "cert-manager"
-  namespace: "cert-manager"
-  installCRDs: true
 # ---
 # Cluster API provider options
 core: ""