refactor: add return type hint for getModel() method in condition cla…

…sses Signed-off-by: Sam Poyigi <[email protected]>
tastyigniter · Feb 27, 2025 · 3d7311e · 3d7311e
1 parent 45fb942
commit 3d7311e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/tests/Classes/BaseConditionTest.php b/tests/Classes/BaseConditionTest.php
@@ -13,7 +13,7 @@
     $model = Mockery::mock(Model::class);
     $condition = new class($model) extends BaseCondition
     {
-        public function getModel()
+        public function getModel(): ?Model
         {
             return $this->model;
         }
@@ -23,13 +23,17 @@ public function getModel()
 });
 
 it('defines a name and description', function(): void {
-    $condition = new class extends BaseCondition {};
+    $condition = new class extends BaseCondition
+    {
+    };
 
     expect($condition->conditionDetails())->toHaveKeys(['name', 'description']);
 });
 
 it('checks condition', function(): void {
-    $condition = new class extends BaseCondition {};
+    $condition = new class extends BaseCondition
+    {
+    };
 
     $params = [];
 

diff --git a/tests/Classes/BaseModelAttributesConditionTest.php b/tests/Classes/BaseModelAttributesConditionTest.php
@@ -15,7 +15,7 @@
     $model = Mockery::mock(Model::class)->makePartial();
     $condition = new class($model) extends BaseModelAttributesCondition
     {
-        public function getModel()
+        public function getModel(): ?Model
         {
             return $this->model;
         }
@@ -103,7 +103,9 @@ public function __construct($operator)
                 ],
             ];
 
-            $this->model = new class($attributes) extends Model {};
+            $this->model = new class($attributes) extends Model
+            {
+            };
         }
 
         public function defineModelAttributes(): array
@@ -137,7 +139,9 @@ public function __construct($operator, $value)
                 ],
             ];
 
-            $this->model = new class($attributes) extends Model {};
+            $this->model = new class($attributes) extends Model
+            {
+            };
         }
 
         public function defineModelAttributes(): array