fix(notification): remove default notification sound on Windows (#440)

amrbashir · web-flow · commit c81dff292afc · 2023-06-18T07:18:20.000-03:00
diff --git a/.changes/notification-revert-sound.md b/.changes/notification-revert-sound.md
@@ -0,0 +1,5 @@
+---
+"notification": patch
+---
+
+Revert [7d71ad4e5](https://github.com/tauri-apps/plugins-workspace/commit/7d71ad4e587bcf47ea34645f5b226945e487b765) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.
diff --git a/plugins/notification/src/desktop.rs b/plugins/notification/src/desktop.rs
@@ -184,9 +184,6 @@ mod imp {
                 {
                     notification.app_id(&self.identifier);
                 }
-
-                // will be parsed as a `::winrt_notification::Sound`
-                notification.sound_name("Default");
             }
             #[cfg(target_os = "macos")]
             {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"notification": patch
 +---
++
 +Revert [7d71ad4e5](https://github.com/tauri-apps/plugins-workspace/commit/7d71ad4e587bcf47ea34645f5b226945e487b765) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.
Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,6 @@ mod imp {`
`184`	`184`	`{`
`185`	`185`	`notification.app_id(&self.identifier);`
`186`	`186`	`}`
`187`		`-`
`188`		- // will be parsed as a `::winrt_notification::Sound`
`189`		`- notification.sound_name("Default");`
`190`	`187`	`}`
`191`	`188`	`#[cfg(target_os = "macos")]`
`192`	`189`	`{`