Skip to content

Commit a63c387

Browse files
committed
Auto merge of #112431 - Urgau:cast_ref_to_mut_improvments, r=Nilstrieb
Improve `invalid_reference_casting` lint This PR is a follow-up to rust-lang/rust#111567 and rust-lang/rust#113422. This PR does multiple things: - First it adds support for deferred de-reference, the goal is to support code like this, where the casting and de-reference are not done on the same expression ```rust let myself = self as *const Self as *mut Self; *myself = Self::Ready(value); ``` - Second it does not lint anymore on SB/TB UB code by only checking assignments (`=`, `+=`, ...) and creation of mutable references `&mut *` - Thirdly it greatly improves the diagnostics in particular for cast from `&mut` to `&mut` or assignments - ~~And lastly it renames the lint from `cast_ref_to_mut` to `invalid_reference_casting` which is more consistent with the ["rules"](rust-lang/rust-clippy#2845) and also more consistent with what the lint checks~~ *rust-lang/rust#113422 This PR is best reviewed commit by commit. r? compiler
2 parents dabec21 + 9fe3a19 commit a63c387

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

core/src/cell.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1893,7 +1893,8 @@ impl<T: ?Sized + fmt::Display> fmt::Display for RefMut<'_, T> {
18931893
/// on an _exclusive_ `UnsafeCell<T>`. Even though `T` and `UnsafeCell<T>` have the
18941894
/// same memory layout, the following is not allowed and undefined behavior:
18951895
///
1896-
/// ```rust,no_run
1896+
#[cfg_attr(bootstrap, doc = "```rust,no_run")]
1897+
#[cfg_attr(not(bootstrap), doc = "```rust,compile_fail")]
18971898
/// # use std::cell::UnsafeCell;
18981899
/// unsafe fn not_allowed<T>(ptr: &UnsafeCell<T>) -> &mut T {
18991900
/// let t = ptr as *const UnsafeCell<T> as *mut T;

0 commit comments

Comments
 (0)