Skip to content

Commit 5632f03

Browse files
committed
Clean up new rename.
1 parent 812d2fd commit 5632f03

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

src/clojure_refactoring/ast/zip.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
zip/path))
1818

1919
(defn zip-walk [zipper f]
20-
"Performs a depth first walk over zipper, calling f on each sub-node."
20+
"Performs a depth first walk over zipper, calling a function
21+
on each sub-node."
2122
(loop [loc zipper]
2223
(if (zip/end? loc)
2324
(zip/root loc)

src/clojure_refactoring/rename.clj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,19 @@
2020
(rename-in-ast ast old new))))
2121

2222
(defn rename-node [loc new-name]
23-
(if ((bindings-above-loc loc) (zip/node loc))
23+
(if ((bindings-above loc) (zip/node loc))
2424
loc
2525
(zip/replace loc (ast/symbol new-name))))
2626

27-
(defn rename-non-shadowed-in-ast [new-sym node old-name]
27+
(defn rename-non-shadowed [new-sym node old-name]
2828
(zip-walk (ast-zip node)
2929
#(if (= (zip/node %) (ast/symbol old-name))
3030
(rename-node % new-sym) %)))
3131

3232
(defn renaming-fn [old-var new-sym]
3333
"Returns a function for renaming nodes"
3434
(fn [node]
35-
(rename-non-shadowed-in-ast new-sym node (.sym old-var))))
35+
(rename-non-shadowed new-sym node (.sym old-var))))
3636

3737
(defn global-rename [ns old-name new-name]
3838
"Sends a list of alists to emacs for processing as renames."

src/clojure_refactoring/support/find_bindings_above_node.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
ast/sub-nodes
1616
(filter ast/symbol?)))
1717

18-
(defn bindings-above-loc [loc]
18+
(defn bindings-above [loc]
1919
(->> (zip/path loc)
2020
(filter ast/binding-node?)
2121
(mapcat extract-symbols-from-binding-node)
2222
set))
2323

2424
(defn find-bindings-above-node [node expr]
2525
(->> (find-node (ast-zip node) expr)
26-
bindings-above-loc))
26+
bindings-above))

0 commit comments

Comments
 (0)