Make app's API more restful (#160)

Author: ianfdk

client/modules/Post/PostActions.js

@@ -26,7 +26,7 @@ export function addPost(post) {
 
 export function addPostRequest(post) {
   return (dispatch) => {
-    fetch(`${baseURL}/api/addPost`, {
+    fetch(`${baseURL}/api/posts`, {
       method: 'post',
       body: JSON.stringify({
         post: {
@@ -51,7 +51,7 @@ export function addSelectedPost(post) {
 
 export function getPostRequest(post) {
   return (dispatch) => {
-    return fetch(`${baseURL}/api/getPost?slug=${post}`, {
+    return fetch(`${baseURL}/api/posts/${post}`, {
       method: 'get',
       headers: new Headers({
         'Content-Type': 'application/json',
@@ -76,18 +76,18 @@ export function addPosts(posts) {
 
 export function fetchPosts() {
   return (dispatch) => {
-    return fetch(`${baseURL}/api/getPosts`).
+    return fetch(`${baseURL}/api/posts`).
     then((response) => response.json()).
     then((response) => dispatch(addPosts(response.posts)));
   };
 }
 
 export function deletePostRequest(post) {
   return (dispatch) => {
-    fetch(`${baseURL}/api/deletePost`, {
-      method: 'post',
+    fetch(`${baseURL}/api/posts`, {
+      method: 'delete',
       body: JSON.stringify({
-        postId: post._id,
+        id: post._id,
       }),
       headers: new Headers({
         'Content-Type': 'application/json',

client/modules/Post/components/PostListItem/PostListItem.js

@@ -8,7 +8,7 @@ function PostListItem(props) {
   return (
     <div className={styles['single-post']}>
       <h3 className={styles['post-title']}>
-        <Link to={`/post/${props.post.slug}-${props.post.cuid}`} onClick={props.onClick}>
+        <Link to={`/posts/${props.post.slug}-${props.post.cuid}`} onClick={props.onClick}>
           {props.post.title}
         </Link>
       </h3>

client/routes.js

@@ -32,7 +32,7 @@ export default (
       }}
     />
     <Route
-      path="/post/:slug"
+      path="/posts/:slug"
       getComponent={(nextState, cb) => {
         require.ensure([], require => {
           cb(null, require('./modules/Post/pages/PostDetailPage/PostDetailPage').default);

server/controllers/post.controller.js

@@ -51,7 +51,7 @@ export function addPost(req, res) { // eslint-disable-line consistent-return
  * @param res
  */
 export function getPost(req, res) {
-  const newSlug = req.query.slug.split('-');
+  const newSlug = req.params.slug.split('-');
   const newCuid = newSlug[newSlug.length - 1];
   Post.findOne({ cuid: newCuid }).exec((err, post) => {
     if (err) {
@@ -67,7 +67,7 @@ export function getPost(req, res) {
  * @param res
  */
 export function deletePost(req, res) {
-  const postId = req.body.postId;
+  const postId = req.body.id;
   Post.findById(postId).exec((err, post) => { // eslint-disable-line consistent-return
     if (err) {
       return res.status(500).send(err);

server/routes/post.routes.js

@@ -3,15 +3,15 @@ import * as PostController from '../controllers/post.controller';
 const router = new Router();
 
 // Get all Posts
-router.route('/getPosts').get(PostController.getPosts);
+router.route('/posts').get(PostController.getPosts);
 
 // Get one post by title
-router.route('/getPost').get(PostController.getPost);
+router.route('/posts/:slug').get(PostController.getPost);
 
 // Add a new Post
-router.route('/addPost').post(PostController.addPost);
+router.route('/posts').post(PostController.addPost);
 
 // Delete a Post
-router.route('/deletePost').post(PostController.deletePost);
+router.route('/posts').delete(PostController.deletePost);
 
 export default router;

server/tests/post.spec.js

@@ -28,7 +28,7 @@ function dropDB(done) {
   });
 }
 
-describe('GET /api/getPosts', function () {
+describe('GET /api/posts', function () {
 
   beforeEach('connect and add two post entries', function (done) {
 
@@ -49,7 +49,7 @@ describe('GET /api/getPosts', function () {
   it('Should correctly give number of Posts', function (done) {
 
     request(app)
-      .get('/api/getPosts')
+      .get('/api/posts')
       .set('Accept', 'application/json')
       .end(function (err, res) {
         Post.find().exec(function (err, posts) {
@@ -60,7 +60,7 @@ describe('GET /api/getPosts', function () {
   });
 });
 
-describe('GET /api/getPost', function () {
+describe('GET /api/posts/:slug', function () {
 
   beforeEach('connect and add one Post entry', function(done){
 
@@ -80,7 +80,7 @@ describe('GET /api/getPost', function () {
   it('Should send correct data when queried against a title', function (done) {
 
     request(app)
-      .get('/api/getPost?slug=bar-f34gb2bh24b24b2')
+      .get('/api/posts/bar-f34gb2bh24b24b2')
       .set('Accept', 'application/json')
       .end(function (err, res) {
         Post.findOne({ cuid: 'f34gb2bh24b24b2' }).exec(function (err, post) {
@@ -92,7 +92,7 @@ describe('GET /api/getPost', function () {
 
 });
 
-describe('POST /api/addPost', function () {
+describe('POST /api/posts', function () {
 
   beforeEach('connect and add a post', function (done) {
 
@@ -108,7 +108,7 @@ describe('POST /api/addPost', function () {
   it('Should send correctly add a post', function (done) {
 
     request(app)
-      .post('/api/addPost')
+      .post('/api/posts')
       .send({ post: { name: 'Foo', title: 'bar', content: 'Hello Mern says Foo' } })
       .set('Accept', 'application/json')
       .end(function (err, res) {
@@ -121,7 +121,7 @@ describe('POST /api/addPost', function () {
 
 });
 
-describe('POST /api/deletePost', function () {
+describe('POST /api/posts', function () {
   var postId;
 
   beforeEach('connect and add one Post entry', function(done){
@@ -148,8 +148,8 @@ describe('POST /api/deletePost', function () {
     });
 
     request(app)
-      .post('/api/deletePost')
-      .send({ postId: postId})
+      .delete('/api/posts')
+      .send({ id: postId})
       .set('Accept', 'application/json')
       .end(function () {