Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Git submodules for third party dependencies #1

Open
wltan opened this issue Jul 1, 2020 · 0 comments
Open

Switch to Git submodules for third party dependencies #1

wltan opened this issue Jul 1, 2020 · 0 comments

Comments

@wltan
Copy link
Member

wltan commented Jul 1, 2020

We currently depend on alexandru-dinu/igcc (and possibly source-academy/js-slang in future) which are GitHub repositories.

In our dockerfiles we clone the repositories when the images are being built, and use that version until the next build. However, the third party repositories might push changes that break our image, so we should migrate ASAP to a submodule implementation so that the dependency remains constant.

https://git-scm.com/book/en/v2/Git-Tools-Submodules
https://www.atlassian.com/git/tutorials/git-submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant