From 8344d5eb3b384fbe83f5cd619ece7a5262caf7a6 Mon Sep 17 00:00:00 2001 From: Kingdon Barrett Date: Sat, 25 Aug 2018 13:36:01 -0400 Subject: [PATCH 1/2] feat(controller): permit setting GUNICORN_WORKERS and CONN_MAX_AGE from global values.yaml --- charts/controller/templates/controller-deployment.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/charts/controller/templates/controller-deployment.yaml b/charts/controller/templates/controller-deployment.yaml index b9a5a688d..83368e461 100644 --- a/charts/controller/templates/controller-deployment.yaml +++ b/charts/controller/templates/controller-deployment.yaml @@ -73,6 +73,10 @@ spec: value: "{{ .Values.global.registry_location }}" - name: "DEIS_REGISTRY_SECRET_PREFIX" value: "{{ .Values.global.secret_prefix }}" + - name: "GUNICORN_WORKERS" + value: "{{ .Values.global.gunicorn_workers }}" + - name: "CONN_MAX_AGE" + value: "{{ .Values.global.conn_max_age }}" - name: "SLUGRUNNER_IMAGE_NAME" valueFrom: configMapKeyRef: From 787faf4b689f367ca1ba6b65b6e0dd41470920ce Mon Sep 17 00:00:00 2001 From: Kingdon Barrett Date: Tue, 4 Sep 2018 20:34:26 -0400 Subject: [PATCH 2/2] feat(controller): document added chart values The controller values.yaml should mention all of the settings that can affect the controller in values.yaml too. --- charts/controller/values.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/charts/controller/values.yaml b/charts/controller/values.yaml index 692793ac7..595be7e1a 100644 --- a/charts/controller/values.yaml +++ b/charts/controller/values.yaml @@ -49,6 +49,21 @@ global: host_port: 5555 # Prefix for the imagepull secret created when using private registry secret_prefix: "private-registry" + # Clusters with large nodes (24 CPU+) may need to lower or tune the number of GUNICORN_WORKERS. + # + # Default value is based on your number of CPUs: + # - (os.cpu_count() or 4) * 4 + 1 + # This setting probably should not be higher than max_connections which defaults to 100 + # gunicorn_workers: 13 + # If there are enough gunicorn workers to use up max_connections, you may also want to reduce CONN_MAX_AGE + # so health checks time out their connection faster and don't use all available connections + # + # Valid values are a number of seconds, or 0 to disable persistent connections. + # Setting the value to "None" will ensure that connections are never timed out. + # - 0 + # - 600 + # - "None" + # conn_max_age: 600 # Experimental feature to toggle using kubernetes ingress instead of the Deis router. # # Valid values are: