Fix duplicate Todo List item IDs (TODO_ITEM_DUPLICATE)#30710
Open
Laky-64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate Todo List item IDs (
TODO_ITEM_DUPLICATE)This PR fixes an issue in Todo List item ID generation that could lead to duplicate IDs being produced and rejected by Telegram with the
TODO_ITEM_DUPLICATEerror.Problem
Previously,
usedIdwas directly overwritten whenever a task already had an ID:This caused a regression scenario when tasks were not strictly ordered by ascending IDs.
For example, if a task with a smaller existing ID appeared after a larger one,
usedIdwould move backwards, allowing newly generated IDs to collide with already used IDs.Fix
The new logic ensures that
usedIdalways keeps the highest ID encountered so far:This guarantees that auto-generated IDs continue monotonically and prevents duplicate Todo List item IDs from being generated.