Skip to content

Commit 8ddf2d9

Browse files
committed
Unskip update tests under java test server
1 parent 341d949 commit 8ddf2d9

File tree

1 file changed

+10
-72
lines changed

1 file changed

+10
-72
lines changed

tests/worker/test_workflow.py

+10-72
Original file line numberDiff line numberDiff line change
@@ -1494,7 +1494,7 @@ async def test_workflow_with_codec(client: Client, env: WorkflowEnvironment):
14941494
await test_workflow_signal_and_query(client)
14951495
await test_workflow_signal_and_query_errors(client)
14961496
await test_workflow_simple_activity(client)
1497-
await test_workflow_update_handlers_happy(client, env)
1497+
await test_workflow_update_handlers_happy(client)
14981498

14991499

15001500
class PassThroughCodec(PayloadCodec):
@@ -4270,11 +4270,7 @@ def throws_runtime_err(self) -> None:
42704270
raise RuntimeError("intentional failure")
42714271

42724272

4273-
async def test_workflow_update_handlers_happy(client: Client, env: WorkflowEnvironment):
4274-
if env.supports_time_skipping:
4275-
pytest.skip(
4276-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4277-
)
4273+
async def test_workflow_update_handlers_happy(client: Client):
42784274
async with new_worker(
42794275
client, UpdateHandlersWorkflow, activities=[say_hello]
42804276
) as worker:
@@ -4316,13 +4312,7 @@ async def test_workflow_update_handlers_happy(client: Client, env: WorkflowEnvir
43164312
)
43174313

43184314

4319-
async def test_workflow_update_handlers_unhappy(
4320-
client: Client, env: WorkflowEnvironment
4321-
):
4322-
if env.supports_time_skipping:
4323-
pytest.skip(
4324-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4325-
)
4315+
async def test_workflow_update_handlers_unhappy(client: Client):
43264316
async with new_worker(client, UpdateHandlersWorkflow) as worker:
43274317
handle = await client.start_workflow(
43284318
UpdateHandlersWorkflow.run,
@@ -4395,11 +4385,7 @@ async def test_workflow_update_handlers_unhappy(
43954385
assert "Rejected" == err.value.cause.message
43964386

43974387

4398-
async def test_workflow_update_task_fails(client: Client, env: WorkflowEnvironment):
4399-
if env.supports_time_skipping:
4400-
pytest.skip(
4401-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4402-
)
4388+
async def test_workflow_update_task_fails(client: Client):
44034389
# Need to not sandbox so behavior can change based on globals
44044390
async with new_worker(
44054391
client, UpdateHandlersWorkflow, workflow_runner=UnsandboxedWorkflowRunner()
@@ -4444,13 +4430,7 @@ def got_update(self) -> str:
44444430
return self._got_update
44454431

44464432

4447-
async def test_workflow_update_before_worker_start(
4448-
client: Client, env: WorkflowEnvironment
4449-
):
4450-
if env.supports_time_skipping:
4451-
pytest.skip(
4452-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4453-
)
4433+
async def test_workflow_update_before_worker_start(client: Client):
44544434
# In order to confirm that all started workflows get updates before the
44554435
# workflow completes, this test will start a workflow and start an update.
44564436
# Only then will it start the worker to process both in the task. The
@@ -4518,13 +4498,7 @@ async def signal(self) -> None:
45184498
self._complete_update = True
45194499

45204500

4521-
async def test_workflow_update_separate_handle(
4522-
client: Client, env: WorkflowEnvironment
4523-
):
4524-
if env.supports_time_skipping:
4525-
pytest.skip(
4526-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4527-
)
4501+
async def test_workflow_update_separate_handle(client: Client):
45284502
async with new_worker(client, UpdateSeparateHandleWorkflow) as worker:
45294503
# Start the workflow
45304504
handle = await client.start_workflow(
@@ -4564,14 +4538,7 @@ async def do_update(self, sleep: float) -> None:
45644538
await asyncio.sleep(sleep)
45654539

45664540

4567-
async def test_workflow_update_timeout_or_cancel(
4568-
client: Client, env: WorkflowEnvironment
4569-
):
4570-
if env.supports_time_skipping:
4571-
pytest.skip(
4572-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4573-
)
4574-
4541+
async def test_workflow_update_timeout_or_cancel(client: Client):
45754542
# Confirm start timeout via short timeout on update w/ no worker running
45764543
handle = await client.start_workflow(
45774544
UpdateTimeoutOrCancelWorkflow.run,
@@ -4861,14 +4828,7 @@ async def run(self, scenario: FailureTypesScenario) -> None:
48614828
await super().run(scenario)
48624829

48634830

4864-
async def test_workflow_failure_types_configured(
4865-
client: Client, env: WorkflowEnvironment
4866-
):
4867-
if env.supports_time_skipping:
4868-
pytest.skip(
4869-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4870-
)
4871-
4831+
async def test_workflow_failure_types_configured(client: Client):
48724832
# Asserter for a single scenario
48734833
async def assert_scenario(
48744834
workflow: Type[FailureTypesWorkflowBase],
@@ -5252,11 +5212,7 @@ async def get_update_id(self) -> str:
52525212
return info.id
52535213

52545214

5255-
async def test_workflow_current_update(client: Client, env: WorkflowEnvironment):
5256-
if env.supports_time_skipping:
5257-
pytest.skip(
5258-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5259-
)
5215+
async def test_workflow_current_update(client: Client):
52605216
async with new_worker(client, CurrentUpdateWorkflow) as worker:
52615217
handle = await client.start_workflow(
52625218
CurrentUpdateWorkflow.run,
@@ -5327,11 +5283,7 @@ async def my_signal_WARN_AND_ABANDON(self):
53275283
await self._do_update_or_signal()
53285284

53295285

5330-
async def test_unfinished_update_handler(client: Client, env: WorkflowEnvironment):
5331-
if env.supports_time_skipping:
5332-
pytest.skip(
5333-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5334-
)
5286+
async def test_unfinished_update_handler(client: Client):
53355287
async with new_worker(client, UnfinishedHandlersWarningsWorkflow) as worker:
53365288
test = _UnfinishedHandlersWarningsTest(client, worker, "update")
53375289
await test.test_wait_all_handlers_finished_and_unfinished_handlers_warning()
@@ -5568,7 +5520,6 @@ async def my_dynamic_signal(self, name: str, args: Sequence[RawValue]) -> None:
55685520
)
55695521
async def test_unfinished_handler_on_workflow_termination(
55705522
client: Client,
5571-
env: WorkflowEnvironment,
55725523
handler_type: Literal["-signal-", "-update-"],
55735524
handler_registration: Literal["-late-registered-", "-not-late-registered-"],
55745525
handler_dynamism: Literal["-dynamic-", "-not-dynamic-"],
@@ -5579,10 +5530,6 @@ async def test_unfinished_handler_on_workflow_termination(
55795530
"-cancellation-", "-failure-", "-continue-as-new-"
55805531
],
55815532
):
5582-
if handler_type == "-update-" and env.supports_time_skipping:
5583-
pytest.skip(
5584-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5585-
)
55865533
await _UnfinishedHandlersOnWorkflowTerminationTest(
55875534
client,
55885535
handler_type,
@@ -5795,12 +5742,7 @@ async def my_update(self) -> str:
57955742

57965743
async def test_update_completion_is_honored_when_after_workflow_return_1(
57975744
client: Client,
5798-
env: WorkflowEnvironment,
57995745
):
5800-
if env.supports_time_skipping:
5801-
pytest.skip(
5802-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5803-
)
58045746
update_id = "my-update"
58055747
task_queue = "tq"
58065748
wf_handle = await client.start_workflow(
@@ -5853,10 +5795,6 @@ async def test_update_completion_is_honored_when_after_workflow_return_2(
58535795
client: Client,
58545796
env: WorkflowEnvironment,
58555797
):
5856-
if env.supports_time_skipping:
5857-
pytest.skip(
5858-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5859-
)
58605798
async with Worker(
58615799
client,
58625800
task_queue="tq",

0 commit comments

Comments
 (0)