Skip to content

Commit ab97443

Browse files
committed
Unskip update tests under java test server
1 parent 09ac120 commit ab97443

File tree

1 file changed

+9
-71
lines changed

1 file changed

+9
-71
lines changed

Diff for: tests/worker/test_workflow.py

+9-71
Original file line numberDiff line numberDiff line change
@@ -4245,11 +4245,7 @@ def throws_runtime_err(self) -> None:
42454245
raise RuntimeError("intentional failure")
42464246

42474247

4248-
async def test_workflow_update_handlers_happy(client: Client, env: WorkflowEnvironment):
4249-
if env.supports_time_skipping:
4250-
pytest.skip(
4251-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4252-
)
4248+
async def test_workflow_update_handlers_happy(client: Client):
42534249
async with new_worker(
42544250
client, UpdateHandlersWorkflow, activities=[say_hello]
42554251
) as worker:
@@ -4291,13 +4287,7 @@ async def test_workflow_update_handlers_happy(client: Client, env: WorkflowEnvir
42914287
)
42924288

42934289

4294-
async def test_workflow_update_handlers_unhappy(
4295-
client: Client, env: WorkflowEnvironment
4296-
):
4297-
if env.supports_time_skipping:
4298-
pytest.skip(
4299-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4300-
)
4290+
async def test_workflow_update_handlers_unhappy(client: Client):
43014291
async with new_worker(client, UpdateHandlersWorkflow) as worker:
43024292
handle = await client.start_workflow(
43034293
UpdateHandlersWorkflow.run,
@@ -4370,11 +4360,7 @@ async def test_workflow_update_handlers_unhappy(
43704360
assert "Rejected" == err.value.cause.message
43714361

43724362

4373-
async def test_workflow_update_task_fails(client: Client, env: WorkflowEnvironment):
4374-
if env.supports_time_skipping:
4375-
pytest.skip(
4376-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4377-
)
4363+
async def test_workflow_update_task_fails(client: Client):
43784364
# Need to not sandbox so behavior can change based on globals
43794365
async with new_worker(
43804366
client, UpdateHandlersWorkflow, workflow_runner=UnsandboxedWorkflowRunner()
@@ -4419,13 +4405,7 @@ def got_update(self) -> str:
44194405
return self._got_update
44204406

44214407

4422-
async def test_workflow_update_before_worker_start(
4423-
client: Client, env: WorkflowEnvironment
4424-
):
4425-
if env.supports_time_skipping:
4426-
pytest.skip(
4427-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4428-
)
4408+
async def test_workflow_update_before_worker_start(client: Client):
44294409
# In order to confirm that all started workflows get updates before the
44304410
# workflow completes, this test will start a workflow and start an update.
44314411
# Only then will it start the worker to process both in the task. The
@@ -4493,13 +4473,7 @@ async def signal(self) -> None:
44934473
self._complete_update = True
44944474

44954475

4496-
async def test_workflow_update_separate_handle(
4497-
client: Client, env: WorkflowEnvironment
4498-
):
4499-
if env.supports_time_skipping:
4500-
pytest.skip(
4501-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4502-
)
4476+
async def test_workflow_update_separate_handle(client: Client):
45034477
async with new_worker(client, UpdateSeparateHandleWorkflow) as worker:
45044478
# Start the workflow
45054479
handle = await client.start_workflow(
@@ -4539,14 +4513,7 @@ async def do_update(self, sleep: float) -> None:
45394513
await asyncio.sleep(sleep)
45404514

45414515

4542-
async def test_workflow_update_timeout_or_cancel(
4543-
client: Client, env: WorkflowEnvironment
4544-
):
4545-
if env.supports_time_skipping:
4546-
pytest.skip(
4547-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4548-
)
4549-
4516+
async def test_workflow_update_timeout_or_cancel(client: Client):
45504517
# Confirm start timeout via short timeout on update w/ no worker running
45514518
handle = await client.start_workflow(
45524519
UpdateTimeoutOrCancelWorkflow.run,
@@ -4836,14 +4803,7 @@ async def run(self, scenario: FailureTypesScenario) -> None:
48364803
await super().run(scenario)
48374804

48384805

4839-
async def test_workflow_failure_types_configured(
4840-
client: Client, env: WorkflowEnvironment
4841-
):
4842-
if env.supports_time_skipping:
4843-
pytest.skip(
4844-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
4845-
)
4846-
4806+
async def test_workflow_failure_types_configured(client: Client):
48474807
# Asserter for a single scenario
48484808
async def assert_scenario(
48494809
workflow: Type[FailureTypesWorkflowBase],
@@ -5227,11 +5187,7 @@ async def get_update_id(self) -> str:
52275187
return info.id
52285188

52295189

5230-
async def test_workflow_current_update(client: Client, env: WorkflowEnvironment):
5231-
if env.supports_time_skipping:
5232-
pytest.skip(
5233-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5234-
)
5190+
async def test_workflow_current_update(client: Client):
52355191
async with new_worker(client, CurrentUpdateWorkflow) as worker:
52365192
handle = await client.start_workflow(
52375193
CurrentUpdateWorkflow.run,
@@ -5302,11 +5258,7 @@ async def my_signal_WARN_AND_ABANDON(self):
53025258
await self._do_update_or_signal()
53035259

53045260

5305-
async def test_unfinished_update_handler(client: Client, env: WorkflowEnvironment):
5306-
if env.supports_time_skipping:
5307-
pytest.skip(
5308-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5309-
)
5261+
async def test_unfinished_update_handler(client: Client):
53105262
async with new_worker(client, UnfinishedHandlersWarningsWorkflow) as worker:
53115263
test = _UnfinishedHandlersWarningsTest(client, worker, "update")
53125264
await test.test_wait_all_handlers_finished_and_unfinished_handlers_warning()
@@ -5543,7 +5495,6 @@ async def my_dynamic_signal(self, name: str, args: Sequence[RawValue]) -> None:
55435495
)
55445496
async def test_unfinished_handler_on_workflow_termination(
55455497
client: Client,
5546-
env: WorkflowEnvironment,
55475498
handler_type: Literal["-signal-", "-update-"],
55485499
handler_registration: Literal["-late-registered-", "-not-late-registered-"],
55495500
handler_dynamism: Literal["-dynamic-", "-not-dynamic-"],
@@ -5554,10 +5505,6 @@ async def test_unfinished_handler_on_workflow_termination(
55545505
"-cancellation-", "-failure-", "-continue-as-new-"
55555506
],
55565507
):
5557-
if handler_type == "-update-" and env.supports_time_skipping:
5558-
pytest.skip(
5559-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5560-
)
55615508
await _UnfinishedHandlersOnWorkflowTerminationTest(
55625509
client,
55635510
handler_type,
@@ -5770,12 +5717,7 @@ async def my_update(self) -> str:
57705717

57715718
async def test_update_completion_is_honored_when_after_workflow_return_1(
57725719
client: Client,
5773-
env: WorkflowEnvironment,
57745720
):
5775-
if env.supports_time_skipping:
5776-
pytest.skip(
5777-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5778-
)
57795721
update_id = "my-update"
57805722
task_queue = "tq"
57815723
wf_handle = await client.start_workflow(
@@ -5828,10 +5770,6 @@ async def test_update_completion_is_honored_when_after_workflow_return_2(
58285770
client: Client,
58295771
env: WorkflowEnvironment,
58305772
):
5831-
if env.supports_time_skipping:
5832-
pytest.skip(
5833-
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
5834-
)
58355773
async with Worker(
58365774
client,
58375775
task_queue="tq",

0 commit comments

Comments
 (0)