Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Avoid losing worker slot on error while processing cache eviction #784

Open
dandavison opened this issue Mar 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

Improve the situation described here:

except Exception as err:
# We cannot fail a cache eviction, we must just log and not complete
# the activation (failed or otherwise). This should only happen in
# cases of deadlock or tasks not properly completing, and yes this
# means that a slot is forever taken.
# TODO(cretz): Should we build a complex mechanism to continually
# try the eviction until it succeeds?
if cache_remove_job:

@dandavison dandavison added the bug Something isn't working label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant