fix/remove imports (#2569)

Author: rossedfort

src/lib/components/event/event-summary-row.svelte

@@ -1,5 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
   import { fade, slide } from 'svelte/transition';
 
   import { page } from '$app/stores';
@@ -46,7 +45,7 @@
   export let expandAll = false;
   export let typedError = false;
   export let active = false;
-  export let onRowClick: () => void = noop;
+  export let onRowClick: () => void = () => {};
 
   $: selectedId = isEventGroup(event)
     ? Array.from(event.events.keys()).shift()

src/lib/components/event/pending-activity-summary-row.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
-
   import { page } from '$app/stores';
 
   import Icon from '$lib/holocene/icon/icon.svelte';
@@ -19,7 +17,7 @@
   export let index: number;
   export let expandAll = false;
   export let active = false;
-  export let onRowClick: () => void = noop;
+  export let onRowClick: () => void = () => {};
 
   $: expanded = expandAll;
   $: ({ workflow, run, namespace } = $page.params);

src/lib/components/event/pending-nexus-summary-row.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
-
   import { page } from '$app/stores';
 
   import Icon from '$lib/holocene/icon/icon.svelte';
@@ -18,7 +16,7 @@
   export let index: number;
   export let expandAll = false;
   export let active = false;
-  export let onRowClick: () => void = noop;
+  export let onRowClick: () => void = () => {};
 
   $: expanded = expandAll;
   $: ({ workflow, run, namespace } = $page.params);

src/lib/components/search-attribute-filter/index.svelte

@@ -1,9 +1,8 @@
 <script lang="ts" context="module">
-  import { afterUpdate } from 'svelte/internal';
   import { writable, type Writable } from 'svelte/store';
   import { fly } from 'svelte/transition';
 
-  import { setContext } from 'svelte';
+  import { afterUpdate, setContext } from 'svelte';
 
   export const FILTER_CONTEXT = 'filter-context';
 

src/lib/components/timezone-select.svelte

@@ -1,5 +1,5 @@
 <script lang="ts">
-  import { onMount } from 'svelte/internal';
+  import { onMount } from 'svelte';
 
   import Icon from '$lib/holocene/icon/icon.svelte';
   import Input from '$lib/holocene/input/input.svelte';

src/lib/components/workflow/workflows-summary-configurable-table/table-row.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
-
   import { getContext } from 'svelte';
 
   import { page } from '$app/stores';
@@ -24,7 +22,7 @@
 
   export let workflow: WorkflowExecution | undefined = undefined;
   export let empty = false;
-  export let viewChildren: (workflow?: WorkflowExecution) => void = noop;
+  export let viewChildren: (workflow?: WorkflowExecution) => void = () => {};
   export let childCount: number | undefined = undefined;
   export let child = false;
 

src/lib/holocene/accordion/accordion.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
   import type { HTMLAttributes } from 'svelte/elements';
-  import { noop } from 'svelte/internal';
 
   import { twMerge as merge } from 'tailwind-merge';
   import { v4 } from 'uuid';
@@ -28,7 +27,7 @@
   export let open = false;
   export let expandable = true;
   export let error = '';
-  export let onToggle = noop;
+  export let onToggle = () => {};
 
   let className = '';
   export { className as class };

src/lib/holocene/calendar.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
-
   import { createEventDispatcher } from 'svelte';
 
   import { getDateRows, weekDays } from '$lib/utilities/calendar';
@@ -41,7 +39,7 @@
       {#if value}
         <button
           type="button"
-          on:click={allowed && value ? () => onChange(value) : noop}
+          on:click={allowed && value ? () => onChange(value) : () => {}}
           class="cell"
           class:highlight={allowed && value}
           class:disabled={!allowed}

src/lib/holocene/filter-or-copy-buttons.svelte

@@ -1,6 +1,4 @@
 <script lang="ts">
-  import { noop } from 'svelte/internal';
-
   import { twMerge as merge } from 'tailwind-merge';
 
   import Icon from '$lib/holocene/icon/icon.svelte';
@@ -10,7 +8,7 @@
   export let filterable = true;
   export let copyable = true;
   export let content: string;
-  export let onFilter: () => void = noop;
+  export let onFilter: () => void = () => {};
   export let filtered = false;
   export let copyIconTitle: string;
   export let copySuccessIconTitle: string;

src/lib/holocene/pill-container/pill.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
   import type { HTMLButtonAttributes } from 'svelte/elements';
-  import { noop } from 'svelte/internal';
 
   import { getContext } from 'svelte';
   import { twMerge as merge } from 'tailwind-merge';
@@ -24,7 +23,7 @@
   } & HTMLButtonAttributes;
 
   export let id: string;
-  export let onClick: () => void = noop;
+  export let onClick: () => void = () => {};
   export let disabled = false;
   export let loading = false;
   export let active: boolean = null;

src/lib/holocene/select/select.svelte

@@ -21,10 +21,9 @@
 
 <script lang="ts">
   import type { HTMLInputAttributes } from 'svelte/elements';
-  import { noop, onMount } from 'svelte/internal';
   import { writable, type Writable } from 'svelte/store';
 
-  import { setContext } from 'svelte';
+  import { onMount, setContext } from 'svelte';
 
   import type { ButtonStyles } from '$lib/holocene/button.svelte';
   import type { IconName } from '$lib/holocene/icon';
@@ -56,7 +55,7 @@
   export let placeholder = '';
   export let disabled = false;
   export let leadingIcon: IconName = null;
-  export let onChange: (value: T) => void = noop;
+  export let onChange: (value: T) => void = () => {};
   export let menuClass: string | undefined = undefined;
   export let variant: ButtonStyles['variant'] = 'secondary';
   export let required = false;

src/lib/holocene/tab/tab.svelte

@@ -1,6 +1,5 @@
 <script lang="ts">
   import type { HTMLAttributes, HTMLButtonAttributes } from 'svelte/elements';
-  import { noop } from 'svelte/internal';
 
   import { getContext } from 'svelte';
 
@@ -29,7 +28,7 @@
   export let panelId: string = null;
   export let disabled = false;
   export let active: boolean = null;
-  export let onClick: () => void = noop;
+  export let onClick: () => void = () => {};
 
   const { registerTab, selectTab, activeTab } = getContext<TabContext>(TABS);
 

src/lib/services/workflow-counts.ts

@@ -1,5 +1,3 @@
-import { noop } from 'svelte/internal';
-
 import type { CountWorkflowExecutionsResponse } from '$lib/types/workflows';
 import { requestFromAPI } from '$lib/utilities/request-from-api';
 import { routeForApi } from '$lib/utilities/route-for-api';
@@ -14,8 +12,8 @@ export const fetchWorkflowCount = async (
     const countRoute = routeForApi('workflows.count', { namespace });
     const result = await requestFromAPI<{ count: string }>(countRoute, {
       params: query ? { query } : {},
-      onError: noop,
-      handleError: noop,
+      onError: () => {},
+      handleError: () => {},
       request,
     });
     count = parseInt(result?.count || '0');

vitest-setup.ts

@@ -1,5 +1,3 @@
-import { noop } from 'svelte/internal';
-
 import i18next from 'i18next';
 import { vi } from 'vitest';
 
@@ -21,8 +19,8 @@ i18next.init({
 });
 
 const BroadcastChannelMock = vi.fn(() => ({
-  addEventListener: noop,
-  postMessage: noop,
+  addEventListener: () => {},
+  postMessage: () => {},
 }));
 
 vi.stubGlobal('BroadcastChannel', BroadcastChannelMock);