Skip to content

Commit d39dd5e

Browse files
authored
Text styles audit (#2236)
* Add responsive font sizing for h1 * Update font family * Add responsive font sizing and update h2 elements * Add responsive font sizing and update other heading elements * Add default font size and weight for body * Remove set icon size in Link component * Add fixed text styles for heading elements and use apply * Add body text style classes to base * Move text styles to separate plugin
1 parent af0d545 commit d39dd5e

File tree

72 files changed

+163
-156
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+163
-156
lines changed

.vscode/settings.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,8 @@
1111
"tailwindCSS.experimental.classRegex": [
1212
["cva\\(([^)]*)\\)", "[\"'`]([^\"'`]*).*?[\"'`]"],
1313
["cx\\(([^)]*)\\)", "(?:'|\"|`)([^']*)(?:'|\"|`)"]
14-
]
14+
],
15+
"files.associations": {
16+
"*.css": "tailwindcss"
17+
}
1518
}

src/app.css

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,14 @@
1010
*,
1111
html,
1212
body {
13-
box-sizing: border-box;
13+
@apply box-border;
1414
}
1515

1616
body {
17-
@apply surface-background;
18-
font-family: theme('fontFamily.primary');
19-
position: relative;
20-
overscroll-behavior: none;
21-
}
22-
23-
h1,
24-
h2,
25-
h3,
26-
h4,
27-
h5,
28-
h6,
29-
titles,
30-
labels {
31-
font-family: theme('fontFamily.secondary');
17+
@apply body-normal surface-background relative overscroll-none;
3218
}
3319

3420
input[type='search']::-webkit-search-cancel-button {
35-
display: none;
21+
@apply hidden;
3622
}
3723
}

src/lib/components/batch-operations/header.svelte

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,17 @@
3232

3333
<div class="flex items-center justify-between">
3434
<div class="flex flex-col gap-2">
35-
<div class="flex flex-row gap-2 max-sm:flex-col">
36-
<h1 class="text-2xl">
35+
<div class="flex flex-row items-center gap-2 max-sm:flex-col">
36+
<h1>
3737
{translate('batch.describe-page-title')}
3838
</h1>
3939
<Badge type={jobStateToBadgeType[operation.state]}>
4040
{operation.state}
4141
</Badge>
4242
</div>
43-
<h2 class="text-sm">
43+
<p>
4444
{operation.jobId}
45-
</h2>
45+
</p>
4646
</div>
4747
{#if operation.state === 'Running'}
4848
<Tooltip

src/lib/components/data-encoder-settings.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
>
8181
<div class="flex w-full flex-col gap-4 xl:w-1/2">
8282
<div class="flex items-center justify-between space-x-2">
83-
<h3 data-testid="data-encoder-title" class="text-xl">
83+
<h3 data-testid="data-encoder-title">
8484
{translate('common.codec-server')}
8585
</h3>
8686
</div>

src/lib/components/lines-and-dots/input-and-results-payload.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</script>
2424

2525
<div class="flex w-full grow flex-col gap-2 py-4 {$$restProps.class}">
26-
<h3 class="flex items-center gap-2 text-2xl">
26+
<h3 class="flex items-center gap-2">
2727
{title}
2828
</h3>
2929
{#if content}

src/lib/components/lines-and-dots/workflow-details.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</script>
2424

2525
<div class="flex flex-col gap-2">
26-
<h3 class="flex items-center text-2xl">Summary</h3>
26+
<h3 class="flex items-center">Summary</h3>
2727
<div
2828
class="surface-primary grid w-full grid-flow-row grid-cols-1 gap-2 rounded-xl border-2 border-primary p-2 md:grid-cols-2 xl:grid-cols-3"
2929
>

src/lib/components/schedule/schedule-day-of-month-view.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</script>
1313

1414
<div class="my-2 flex flex-col gap-4">
15-
<h3 class="text-lg font-medium">
15+
<h3>
1616
{translate('schedules.recurring-dates-heading')}
1717
</h3>
1818
<p>{translate('schedules.recurring-dates-description')}</p>

src/lib/components/schedule/schedule-day-of-week-view.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</script>
1111

1212
<div class="my-2 flex flex-col gap-4">
13-
<h3 class="text-lg font-medium">
13+
<h3>
1414
{translate('schedules.recurring-days-heading')}
1515
</h3>
1616
<p>{translate('schedules.recurring-days-description')}</p>

src/lib/components/schedule/schedule-form-view.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
<Link href={backHref} icon="chevron-left">
143143
{backTitle}
144144
</Link>
145-
<h1 class="font-base text-2xl">{title}</h1>
145+
<h1>{title}</h1>
146146
</header>
147147
<form class="mb-4 flex w-full flex-col gap-4 md:w-2/3 xl:w-1/2">
148148
<Alert intent="error" title="" hidden={!$error}>

src/lib/components/schedule/schedule-frequency-panel.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</script>
1414

1515
<Panel>
16-
<h2 class="mb-4 text-lg">{translate('schedules.schedule-spec')}</h2>
16+
<h2 class="mb-4">{translate('schedules.schedule-spec')}</h2>
1717
<div class="pr-2">
1818
<ScheduleFrequency {calendar} {interval} {timezoneName} class="text-base" />
1919
</div>

0 commit comments

Comments
 (0)